#silverstripe IRC Log

IRC log for 19 March 2013

All timestamps are in UTC.

1: [00:06:00] <Pyromanik> defualt
2: [00:06:00] <Pyromanik> ss23, yeah, turns out the a and the u were backwards
3: [00:08:00] <ss23> Pyromanik: Yay! I make mistakes like that so often >.<
4: [00:09:00] <Pyromanik> ss23, wasn't me who made it, but we were peer coding, so I still should have seen it :<
5: [00:10:00] * azureKnight_ has joined #silverstripe
6: [00:11:00] * azureKnight quit (Ping timeout: 245 seconds)
7: [00:11:00] * azureKnight_ is now known as azureKnight
8: [00:11:00] * azureKnight quit (Client Quit)
9: [00:12:00] * chillu quit (Quit: chillu)
10: [00:15:00] * C10ne quit (Ping timeout: 245 seconds)
11: [00:16:00] <ss23> okay, now time to clean up all that horribly hrorible Javascript I wrote last night
12: [00:16:00] <ss23> http://doc.silverstripe.com/framework/en/topics/javascript Important: Parts of this guide apply to the SilverStripe 2.4 release, particularly around the jQuery.entwine library. - I take it that means 2.4 and above?
13: [00:17:00] <ss23> As in, most of that applies to 3.0 too, right?
14: [00:21:00] <Pyromanik> entwine does
15: [00:22:00] <Pyromanik> but things like using jquery's live shouldn't be done anymore
16: [00:22:00] <Pyromanik> use on instead.
17: [00:22:00] <Pyromanik> etc
18: [00:23:00] <ss23> I should learn Javascript one day
19: [00:24:00] <ss23> Javascript scope and stuff always messes me up
20: [00:28:00] <discorpia> like that
21: [00:28:00] <discorpia> i saw on reddit that prettydiff can colorize on scope
22: [00:28:00] <discorpia> http://prettydiff.com/jspretty.xhtml?c=white&jsscope&s=http://prettydiff.com/lib/markup_beauty.js
23: [00:29:00] * ajshort has joined #silverstripe
24: [00:30:00] <Pyromanik> that's just colourising functions
25: [00:30:00] <Pyromanik> scope is a bit more complex than that :<
26: [00:30:00] <discorpia> oh sorry, hadn't looked very close at it, just came to mind
27: [00:30:00] <Pyromanik> closures
28: [00:30:00] <Pyromanik> ergh, nah
29: [00:39:00] <simon_w> No var: global scope
30: [00:39:00] <simon_w> It's kinda the opposite of the way PHP does it
31: [00:39:00] <ss23> Okay so here's what I'm doing
32: [00:40:00] <discorpia> simon_w: isn't that also how c and other c-based languages does it? it feels like php is the exception with that approach
33: [00:40:00] <ss23> The issue seems to be that once that code runs once, it always serliaizes to the same value
34: [00:40:00] <ss23> Let me paste the entire code though
35: [00:40:00] <ss23> It seems like on the first .submit() call, it "executes", then after that it's "cached" and just sets the value how I wouldn't expect
36: [00:40:00] <ss23> jQuery('#map-select').parents('form').submit(function() { // Serliaize some stuff into a hidden form field here with .val() and stuff }
37: [00:41:00] <ss23> https://gist.github.com/ss23/5192506
38: [00:41:00] <simon_w> discorpia, nope. C defaults to local scope, just like PHP
39: [00:42:00] * liam_ has joined #silverstripe
40: [00:42:00] <ss23> So, I want to every time the submit is pressed, update the hiddne field with the new values from map, but it seems like after it does the first submit(), it'll always use those map values if you press submit again
41: [00:42:00] * liam_ is now known as Guest83326
42: [00:43:00] <discorpia> simon_w: hmm, if i address a variable that has not been locally declared c defaults to global scope, no?
43: [00:45:00] <simon_w> discorpia, it doesn't compile
44: [00:46:00] <discorpia> what?
45: [00:46:00] <simon_w> you know, the whole "error: ?blah? undeclared (first use in this function)"
46: [00:46:00] <simon_w> If you try to access a variable that doesn't exist, it doesn't compile
47: [00:47:00] <discorpia> maybe i'm misunderstanding the term defaults
48: [00:47:00] <simon_w> And I should lunch
49: [00:48:00] <ss23> simon_w: I had chocolate and coke :D
50: [00:48:00] <discorpia> i'm thinking fallback
51: [00:48:00] * hubertusanton quit (Ping timeout: 248 seconds)
52: [00:49:00] <discorpia> i feel javascript and c behave equally since redeclaring a variable in a new scope overrides the global, whereas php requires you to import the global variable
53: [00:50:00] <terryapodaca> did simon_w go to lunch?
54: [00:50:00] * hubertusanton has joined #silverstripe
55: [00:51:00] * ss23 pokes simon_w - did you leave yet?
56: [00:51:00] <ss23> terryapodaca: Probably not yet
57: [00:52:00] <terryapodaca> looks like he did
58: [00:52:00] <terryapodaca> oh well
59: [01:02:00] <Pyromanik> <discorpia> i feel javascript and c behave equally since redeclaring a variable in a new scope overrides the global, whereas php requires you to import the global variable
60: [01:02:00] <Pyromanik> javascript functions can use variables from it's parent scope if it's a closure.
61: [01:02:00] <Pyromanik> c will give you an error, ti doesn't automaticallly pull the global scope in, same like php.
62: [01:03:00] <Pyromanik> however with php you can pull in global vars with the global keyword
63: [01:03:00] <Pyromanik> so you can redefine whatever you want.
64: [01:04:00] <ss23> Delicious!
65: [01:04:00] <simon_w> Yeah
66: [01:04:00] <simon_w> ss23, still has to be imported!
67: [01:04:00] <Pyromanik> :<
68: [01:04:00] <Pyromanik> header files :/
69: [01:04:00] <simon_w> C does look at file scope
70: [01:04:00] <ss23> simon_w: Did you get lunch?
71: [01:04:00] <simon_w> yes
72: [01:04:00] <ss23> :D
73: [01:04:00] <ss23> What did you get?
74: [01:04:00] <Pyromanik> simon_w, yeh, that's true.
75: [01:04:00] <Pyromanik> been a while since I C'd
76: [01:04:00] <simon_w> Some sort of roll thing and some chocolate
77: [01:04:00] <Pyromanik> but there's no "global" scope.
78: [01:04:00] <ss23> Pyromanik: extern!
79: [01:05:00] <ss23> I don't know C well :D
80: [01:07:00] <ss23> grrr
81: [01:10:00] <terryapodaca> ?
82: [01:10:00] <terryapodaca> simon_w: one last quick question, if you have a minute
83: [01:10:00] <terryapodaca> he left again?
84: [01:10:00] <ss23> terryapodaca: Ask it now so that he can answer when he's back :)
85: [01:11:00] <ss23> terryapodaca: People don't stay with IRC up 24/7, we do other things at the same time. If you ask it sooner, it'll get anaswered sooner
86: [01:11:00] <simon_w> Or, ask it so I can answer it :p
87: [01:11:00] <terryapodaca> well crap
88: [01:12:00] <ss23> Dammit, my maps stuff works on a JSFiddle, but not in the CMS :<
89: [01:12:00] <terryapodaca> http://www.sspaste.com/paste/show/5147a269a696c
90: [01:12:00] <terryapodaca> i get that error...and sure...
91: [01:12:00] <terryapodaca> I added the new class to the search...and it kind of works
92: [01:13:00] <terryapodaca> because I can't get the 'custom' content from my SuccessStoriesPage
93: [01:13:00] <terryapodaca> how do I change the first part of the query so search FROM "SuccessStoriesPage"
94: [01:14:00] <simon_w> And how are you building the query?
95: [01:14:00] <terryapodaca> like the image, custom title, etc...
96: [01:14:00] <terryapodaca> city, state....etc
97: [01:15:00] <terryapodaca> I added the correct code to the SearchForm.php file
98: [01:15:00] <terryapodaca> same for FulltextSearchable.php
99: [01:16:00] <terryapodaca> public function searchEngine() is where it all takes place...
100: [01:16:00] <terryapodaca> and I had to find a couple placces in MySQLDatabase.php...
101: [01:16:00] <terryapodaca> but I can't figure out where that first part is being built
102: [01:17:00] <terryapodaca> i'll sspates it
103: [01:17:00] <simon_w> And I don't have that sitting around :p
104: [01:17:00] <terryapodaca> give me a second
105: [01:19:00] <terryapodaca> http://www.sspaste.com/paste/show/5147bd1fa0f3f
106: [01:19:00] <terryapodaca> but then again, i could be way off in trying to add SuccessStoriesPage to the search
107: [01:21:00] * catcher quit (Quit: Leaving)
108: [01:25:00] <simon_w> Well, line 80 is what's taking out the needed joins
109: [01:26:00] <simon_w> could change that to start with if($class != 'SuccessStoriesPage')
110: [01:27:00] <simon_w> Also, your match() isn't going to work, since you can't have full text indexes across joins
111: [01:29:00] <terryapodaca> so in other words...i probably can't achieve what I want this way
112: [01:30:00] <simon_w> Would be so much easier if SuccessStoriesPage was its own DataObject
113: [01:30:00] <simon_w> Probably
114: [01:31:00] <ss23> simon_w: I have a bug in my Javascript and I can't replicate it on a jsfiddle or find out what the bug actually is... can I give you a login to my CMS and get you to take a look please? ;_;
115: [01:31:00] <simon_w> ss23, just pastie your JS
116: [01:31:00] <ss23> simon_w: I already diud
117: [01:32:00] <simon_w> I'm not scrolling :p
118: [01:32:00] <ss23> First one is
119: [01:32:00] <terryapodaca> would I have been better off doing this with the SearchContext?
120: [01:32:00] <ss23> There are two problems
121: [01:32:00] <ss23> https://gist.github.com/ss23/5192506
122: [01:32:00] <ss23> "Uncaught SyntaxError: Unexpected token , "
123: [01:32:00] <terryapodaca> yeah, it's just a class that extends Page (which is essentially a DataObject
124: [01:32:00] <ss23> Which happens when you press submit and it's in an eval()
125: [01:32:00] <ss23> Which makes me have no idea how to fix.
126: [01:33:00] <simon_w> try dropping the quotes
127: [01:33:00] <simon_w> ss23, that will probably be it complaining about the [name='MapOptions']
128: [01:33:00] <ss23> The code works fine in a jsfiddle - http://jsfiddle.net/EpuMS/1/
129: [01:34:00] <simon_w> Different jQuery versions
130: [01:34:00] <ss23> you were wrong
131: [01:34:00] <ss23> I hate that it happens in an eval so I have no idea how to debug
132: [01:34:00] <ss23> "Uncaught SyntaxError: Unexpected token , "
133: [01:34:00] <ss23> wait no
134: [01:34:00] <ss23> ah yep
135: [01:34:00] <ss23> I just copied of the jQuery page, hence why I left the quotes in
136: [01:34:00] <ss23> :O*
137: [01:34:00] <ss23> Oh, you were right though it seems, simon_w :P
138: [01:34:00] <ss23> doing that now, but why would it only complain in Silverstripe and not on jsfiddle?
139: [01:34:00] <ss23> It just took way longer this time
140: [01:35:00] * UncleCheese quit (Quit: UncleCheese)
141: [01:35:00] <ss23> None of my code evne has a , in it >.<
142: [01:36:00] <ss23> Not particularly, I just want it to work.
143: [01:36:00] <ss23> There's also an issue with it saying "google is undefined" on the first load
144: [01:36:00] <simon_w> Also, are you sure you want map to be global?
145: [01:37:00] * UncleCheese has joined #silverstripe
146: [01:37:00] * terryapodaca quit (Quit: Leaving.)
147: [01:37:00] <ss23> Which is annoying, since I wrapped it in a ready.>.<
148: [01:39:00] <simon_w> Do you have any idea on how to use dev tools to debug javascript?
149: [01:40:00] <ss23> Basic debugging, yes. I know I can type stuff in there, which I was doing to make sure my selectors etc worked. However, because this is an eval() call, it's got thousands of calls of internal jQuery stuff and I can't find out what part of my code is causing it
150: [01:41:00] <simon_w> You can set Chrome up to stop on uncaught exceptions. This means you get the call stack
151: [01:41:00] <ss23> I can already seen the call stack, right? Like, thats what happens whne you expand the exception?
152: [01:41:00] <ss23> anonfunction, globaleval, anon function, extend.each, etc etc
153: [01:42:00] <ss23> but uh, I found some weird stuff, the bug looks in a different place to where I thought it was, so I'm confused, one min
154: [01:43:00] <ss23> It's just so annoying that it works perfectly on jsfiddle
155: [01:43:00] <ss23> I mean, I commented lots out
156: [01:44:00] <ss23> When I comment most of it out like https://gist.github.com/ss23/5192974 it still gives that syntax error
157: [01:45:00] <ss23> simon_w :<
158: [01:45:00] <ss23> Pyromanik~
159: [01:47:00] <Pyromanik> with what?
160: [01:47:00] <ss23> Pyromanik: ;_;
161: [01:47:00] <Pyromanik> I'm busy, I ain't reading your wall of text
162: [01:47:00] <Pyromanik> wut
163: [01:47:00] <ss23> Pyromanik: Halp ;_;
164: [01:48:00] <ss23> Pyromanik: (a jquery eval, not my own eval)
165: [01:48:00] <ss23> Pyromanik: My Javascript gives a snytax error but its inside an eval() so I don't know how to debug. The same code works on jsfiddle. What do
166: [01:50:00] <Pyromanik> lolwut
167: [01:51:00] <ss23> YEAH
168: [01:51:00] <ss23> HOW TO FIX
169: [01:52:00] <Pyromanik> I just make people put in a google maps link
170: [01:52:00] <Pyromanik> sux2bu
171: [01:52:00] <Pyromanik> screw that api bollocks
172: [01:53:00] <Pyromanik> which jq version?
173: [01:53:00] <ss23> Whatever jquery is in latest 3 stable :O
174: [01:55:00] <Pyromanik> jq3?
175: [01:55:00] <Pyromanik> seems FF block derpy double submit anyways
176: [01:55:00] <Pyromanik> derp
177: [01:57:00] <ss23> yeah, something like that
178: [01:57:00] <Pyromanik> oh, ss3.0 framework/thirdparty/jquery/jquery.min.js?
179: [01:58:00] <Pyromanik> Chrome IS the new IE
180: [01:58:00] <Pyromanik> saying it again
181: [01:58:00] <ss23> "/silverstripe/SilverStripe-cms-v3.0.5/framework/thirdparty/jquery/jquery.js?m=1361322165
182: [01:58:00] <ss23> jQuery JavaScript Library v1.7.2
183: [01:58:00] <Pyromanik> 1.7.something iirxc
184: [01:58:00] <ss23> jsfiddle still works fine, Pyromanik
185: [01:58:00] * ss23 changes his fiddle to see if it breaks now
186: [01:58:00] <Pyromanik> boom
187: [01:59:00] <ss23> y u no help me, Pyromanik :<
188: [01:59:00] * Pyromanik rags on the submit button, suddenly 13 dataobjects
189: [02:01:00] <Pyromanik> because complain to #jquery
190: [02:03:00] <ss23> gyuu
191: [02:03:00] <ss23> They'll be mad that I can't reproduce on jsfiddle
192: [02:04:00] * Jakx has joined #silverstripe
193: [02:05:00] <Jakx> yo
194: [02:05:00] <simon_w> Oops, put chocolate under the vents on my screen
195: [02:06:00] <Jakx> lol simon_w
196: [02:07:00] <ss23> Knnow that feel, I used to have external HDD, only left a block of chocolate on top of it once
197: [02:07:00] <ss23> simon_w: XD
198: [02:09:00] <Jakx> resourcecontroller/view/1 works fine
199: [02:09:00] <Jakx> http://www.sspaste.com/paste/show/5147c8d863f1e
200: [02:10:00] * nickmolhoek quit (Quit: nickmolhoek)
201: [02:10:00] <Jakx> is my routes entry correct ^?
202: [02:10:00] <Jakx> but resource/view/1 doesn't do anything
203: [02:11:00] <Jakx> simon_w, ty
204: [02:11:00] <simon_w> Jakx, resource//
205: [02:12:00] <Jakx> what is the '//' representative of?
206: [02:13:00] <Jakx> simon_w, understood
207: [02:13:00] <simon_w> cut point
208: [02:13:00] <simon_w> so those variables are still available for the next matching (inside of Controller)
209: [02:14:00] * nickmolhoek has joined #silverstripe
210: [02:14:00] * nickmolhoek has joined #silverstripe
211: [02:14:00] * nickmolhoek quit (Remote host closed the connection)
212: [02:28:00] * Jakx has left #silverstripe
213: [02:35:00] * UncleCheese has left #silverstripe
214: [02:40:00] <Pyromanik> simon_w, what does it mean when I have an Undefined variable notice when the variable is defined on the line DIRECTLY above the one throwing the error?
215: [02:41:00] <Pyromanik> I don't understand how it possibles :<
216: [02:43:00] <Pyromanik> oh derp derp, no braces on if
217: [02:44:00] <Pyromanik> >< I thought form fields that didn't exist on an object were just ignored when using $form->saveInto()
218: [02:50:00] <Pyromanik> I thought throwing a validation error should bubble all the way back up to form?
219: [02:54:00] <ss23> The more I think about this, the more I can't help but think it's some kind of conflict / Silverstripe issue.
220: [02:57:00] <Pyromanik> are you closing?
221: [03:01:00] <ss23> I swear
222: [03:01:00] <ss23> What is closing
223: [03:01:00] <ss23> THE SAVE BUTTON ISn'T EVNE TOUCHED BY MY CODE
224: [03:01:00] <ss23> HOW DOES THIS HAPPEN
225: [03:01:00] <ss23> If I don't define this variable, no syntax error when you click save
226: [03:01:00] <ss23> I define a variable, and it causes a syntax error when you click save
227: [03:03:00] * Error404NotFound quit (Disconnected by services)
228: [03:04:00] <ss23> Pyromanik: ;_;
229: [03:04:00] * Err404NotFound has joined #silverstripe
230: [03:04:00] * ss23 cries
231: [03:19:00] * DrCuriosity quit (Ping timeout: 258 seconds)
232: [03:20:00] <Pyromanik> syntax error
233: [03:20:00] <Pyromanik> or something
234: [03:21:00] <ss23> I really need someone familiar with Silverstripe to debug this for me. The fact that the sytnax error happens *outside* of my code makes it so damn near impossible for me to fix it without knowing all about this other crap
235: [03:21:00] <Pyromanik> nothing to do with SS, it's a JS error.
236: [03:21:00] <Pyromanik> closure: ;(function($){ /* your jquery code here */ }(jQuery));
237: [03:22:00] <Pyromanik> (I don't know how, so don't ask me)
238: [03:22:00] <Pyromanik> in which case you should l2include properly
239: [03:22:00] <Pyromanik> unless you're in the CMS
240: [03:22:00] <ajshort> ss23: what's the code?
241: [03:23:00] <ss23> ajshort: https://gist.github.com/ss23/5193401
242: [03:23:00] <ajshort> and the error is?
243: [03:23:00] <ss23> Comment that out, it works
244: [03:23:00] <ss23> Leave it uncommented, error when you click submit.
245: [03:25:00] <ajshort> also, you should avoid using global variables
246: [03:25:00] <ss23> ajshort: http://screencast.com/t/iWrkHdGPLeMM
247: [03:25:00] <ss23> I know about global variables being bad, but I'm more interested in doing anything to get it working at the moment :P
248: [03:27:00] <ss23> uh
249: [03:27:00] <ajshort> just use Requirements::javascript()
250: [03:27:00] <ajshort> no
251: [03:27:00] <ajshort> ss23: how are you including your JS? is it inline?
252: [03:27:00] <ss23> HTMLLiteralField, ajshort
253: [03:27:00] <ajshort> no no no
254: [03:27:00] <ss23> LiteralField
255: [03:28:00] * Guest83326 quit (Quit: Guest83326)
256: [03:28:00] <ajshort> LiteralField might be mucking with your JS, who knows
257: [03:28:00] <ajshort> Use proper inclusion
258: [03:28:00] <ajshort> that way it won't be evaled by jquery, so if there is an error you'll get an actual useful error message
259: [03:28:00] <ss23> I can, but I was just using this as a hack so I can test if it works
260: [03:31:00] * azureKnight has joined #silverstripe
261: [03:31:00] * azureKnight quit (Client Quit)
262: [03:32:00] * SightUnseen has joined #silverstripe
263: [03:32:00] * SightUnseen has left #silverstripe
264: [03:35:00] <ss23> Reason it was that code is because that code is dynamically generated with PHP, but when the PHP "fails" (idek how Silverstripe manages to make it fail) it has errors
265: [03:35:00] <ss23> Okay, found it. It does an AJAX request when you click save, and the request seems to be made in such a way that my PHP code doesn't actually run properly, so it returns a bunch of Javascript with syntax errors in it
266: [03:35:00] <ss23> So yeah, that should fix I guess, ajshort
267: [03:36:00] <ss23> Well, the more you know...
268: [03:38:00] * priithansen quit (Quit: priithansen)
269: [03:53:00] * liam_ has joined #silverstripe
270: [03:53:00] * liam_ is now known as Guest70984
271: [04:00:00] * Pyromanik quit (Quit: Leaving)
272: [04:01:00] * DigNZ quit (Quit: DigNZ)
273: [04:09:00] * nickmolhoek quit (Quit: nickmolhoek)
274: [04:22:00] <ss23> wahaha, Allegro RomPager is the second most used webserver in the world
275: [04:24:00] * Err404NotFound quit (Quit: User guilty of hitting the Big Red X...)
276: [04:29:00] * DrCuriosity has joined #silverstripe
277: [04:29:00] * Guest70984 quit (Quit: Guest70984)
278: [04:34:00] <simon_w> You know, after Apache, nginix and IIS!
279: [04:35:00] * liam_ has joined #silverstripe
280: [04:35:00] * liam_ is now known as Guest84255
281: [04:36:00] <ss23> http://internetcensus2012.bitbucket.org/paper.html Check out 6.4
282: [04:36:00] <ss23> They scanned 70.84 million IPs, Allegro RomPager came second
283: [04:36:00] <ss23> (Technically only counts port 80 I guess, but still, a good metric I would say)
284: [04:36:00] <ss23> simon_w: No
285: [04:36:00] <ss23> After Apache, but nothing else
286: [04:39:00] * Error404NotFound has joined #silverstripe
287: [04:41:00] <ss23> Embedded server
288: [04:41:00] <Bollig|DesignCty> wtf is Allegro RomPager?!
289: [04:41:00] <Bollig|DesignCty> some sort of hardware server eh...
290: [04:42:00] <ss23> AND TOASTERS!
291: [04:42:00] <ss23> I want it.
292: [04:42:00] <ss23> In any case, a 420k node botnet...
293: [04:42:00] <Bollig|DesignCty> and toasters.
294: [04:42:00] <ss23> That's really just a reflection of how many people have crap like webcams and things connected to the internet directly
295: [04:49:00] * willr quit (Quit: willr)
296: [04:50:00] * cloph_away1 has joined #silverstripe
297: [04:52:00] * cloph_away quit (Ping timeout: 248 seconds)
298: [04:53:00] <simon_w> That's what they all say
299: [04:55:00] * guci0 has joined #silverstripe
300: [04:55:00] <guci0> Hi all!
301: [04:56:00] <ss23> hai2u
302: [04:57:00] * SightUnseen has left #silverstripe
303: [04:57:00] * SightUnseen has joined #silverstripe
304: [05:02:00] <ss23> Is Behaviour meant to be defined in the CMS so you can hook things like http://doc.silverstripe.com/framework/en/topics/javascript describes?
305: [05:07:00] <ss23> Ah, been deprecated and docs out of date it seems
306: [05:08:00] <travis-ci> [travis-ci] Build details : http://travis-ci.org/silverstripe/sapphire/builds/5616798
307: [05:08:00] * travis-ci has left #silverstripe
308: [05:08:00] <travis-ci> [travis-ci] Change view : https://github.com/silverstripe/sapphire/compare/89ccdd187d83...a40c1f99fc02
309: [05:08:00] <travis-ci> [travis-ci] silverstripe/sapphire#1677 (user-specific-temp-folder - a40c1f9 : Sam Minnee): The build is still failing.
310: [05:08:00] * travis-ci has joined #silverstripe
311: [05:17:00] <ss23> Grrr
312: [05:17:00] <ss23> I've just realised, this code won't work...
313: [05:17:00] <ss23> Silverstripe makes Javascript so insanely complicated :<
314: [05:35:00] * Guest84255 quit (Quit: Guest84255)
315: [05:40:00] * SightUnseen has joined #silverstripe
316: [05:41:00] * SightUnseen has left #silverstripe
317: [06:00:00] * simon_w|air has joined #silverstripe
318: [06:03:00] * aaron1245 quit (Quit: aaron1245)
319: [06:08:00] * Motoservo quit (Quit: Motoservo)
320: [06:10:00] * Motoservo has joined #silverstripe
321: [06:15:00] * aaron1245 has joined #silverstripe
322: [06:35:00] * Squandered quit ()
323: [06:52:00] * Error404NotFound quit (Disconnected by services)
324: [06:59:00] * SightUnseen has joined #silverstripe
325: [07:03:00] * travis-ci has left #silverstripe
326: [07:03:00] <travis-ci> [travis-ci] Change view : https://github.com/ajshort/sapphire/compare/c938c1cecaaf...6b90cacafc2d
327: [07:03:00] <travis-ci> [travis-ci] Build details : http://travis-ci.org/ajshort/sapphire/builds/5618561
328: [07:03:00] * travis-ci has joined #silverstripe
329: [07:03:00] <travis-ci> [travis-ci] ajshort/sapphire#23 (http - 6b90cac : Andrew Short): The build is still failing.
330: [07:04:00] * aaron1245 quit (Quit: aaron1245)
331: [07:09:00] * SightUnseen has left #silverstripe
332: [07:10:00] <ajshort> simon_w|air: I already tried
333: [07:10:00] <simon_w|air> ajshort, still failing! Fix it!
334: [07:10:00] <ajshort> It's a very strange issue
335: [07:11:00] <simon_w|air> Emails are great :p
336: [07:11:00] <ajshort> Feel free to give it a go :)
337: [07:11:00] <ajshort> simon_w|air: BTW, I updated by HTTP changes patch to remove the namespace class renames
338: [07:11:00] <simon_w|air> I saw
339: [07:11:00] * gelignite quit (Quit: http://bit.ly/nkczDT)
340: [07:12:00] <simon_w|air> Are the two 127 character lines in HTTPTest.php yours?
341: [07:12:00] <ajshort> doesn't look like it
342: [07:13:00] <simon_w|air> I'll blame Hamish then
343: [07:13:00] <ajshort> simon_w|air: apart from that, does it look ok?
344: [07:13:00] <simon_w|air> I'll go looks :)
345: [07:14:00] <simon_w|air> Whoa, lots of commits
346: [07:16:00] * DrCuriosity quit (Ping timeout: 256 seconds)
347: [07:36:00] <simon_w|air> substr($blah, 0, 1). Rather long way of doing $blah[0] :p
348: [07:36:00] <ss23> They can act different, if you have mb_overide on, simon_w
349: [07:39:00] <ajshort> simon_w|air: Does that throw a notice if the string is empty?
350: [07:39:00] <ajshort> I can never remember
351: [07:41:00] <ajshort> doesn't look like it does, I can change that
352: [07:43:00] <simon_w|air> Well, it does
353: [07:44:00] <simon_w|air> And, of course, it doesn't work with numbers
354: [07:44:00] <simon_w|air> Well, I think I'm done
355: [07:47:00] <simon_w|air> I was actually looking at the isRedirect(), but yeah
356: [07:47:00] <ajshort> ah yep, that should be an integer
357: [07:47:00] <ajshort> thanks for looking over that
358: [07:47:00] <ajshort> simon_w|air: in that case, I won't change it :)
359: [07:47:00] <ajshort> Since I imagine the URL could be an empty string pretty easily
360: [07:48:00] <simon_w|air> And I still don't get the reasons for PSR-0 :p
361: [07:50:00] <travis-ci> [travis-ci] Build details : http://travis-ci.org/silverstripe/sapphire/builds/5618952
362: [07:50:00] * travis-ci has joined #silverstripe
363: [07:50:00] <travis-ci> [travis-ci] Change view : https://github.com/silverstripe/sapphire/compare/4ac9c23702e6...15d325633a13
364: [07:50:00] * travis-ci has left #silverstripe
365: [07:50:00] <travis-ci> [travis-ci] silverstripe/sapphire#1680 (3.0 - 15d3256 : Andrew Short): The build is still failing.
366: [07:53:00] * simon_w|air is also still waiting for github to suck less
367: [07:54:00] <simon_w|air> 50 KiB/s! Woo!
368: [07:58:00] <ss23> Was annoying though
369: [07:58:00] <ss23> simon_w|air: Could be worse. Had some issues with gitorious where I would get ~2kB/s in AU
370: [07:58:00] <ss23> Seemed to be a failing geo thing, cause go via my AU VPS -> decent speeds
371: [07:59:00] <ss23> Nope
372: [07:59:00] <simon_w|air> Using google's DNS?
373: [08:00:00] <simon_w|air> Also, get cable. DNS servers work great.
374: [08:00:00] <ss23> ;_;
375: [08:00:00] <simon_w|air> Ha, I can! :p
376: [08:00:00] <ss23> I want to use it here, since Telstras fucks up for me so often ,but because of their stupid transparent proxy shit I can't :<
377: [08:01:00] <ss23> Sure
378: [08:01:00] <simon_w|air> I get fibre from my weet-bix!
379: [08:01:00] <ss23> :P
380: [08:01:00] <ss23> Let me just pay the millinos to get cable here
381: [08:01:00] * simon_w|air <3s VF Fixed :p
382: [08:01:00] <ss23> Instead of just getting fibre
383: [08:02:00] * DrCuriosity has joined #silverstripe
384: [08:06:00] * chillu has joined #silverstripe
385: [08:11:00] * zfmf has joined #silverstripe
386: [08:23:00] * travis-ci has left #silverstripe
387: [08:23:00] <travis-ci> [travis-ci] Build details : http://travis-ci.org/ajshort/sapphire/builds/5619461
388: [08:23:00] <travis-ci> [travis-ci] Change view : https://github.com/ajshort/sapphire/compare/6b90cacafc2d...2c68e120fbf0
389: [08:23:00] <travis-ci> [travis-ci] ajshort/sapphire#24 (http - 2c68e12 : Andrew Short): The build is still failing.
390: [08:23:00] * travis-ci has joined #silverstripe
391: [08:25:00] * travis-ci has left #silverstripe
392: [08:25:00] * travis-ci has joined #silverstripe
393: [08:25:00] <travis-ci> [travis-ci] simonwelsh/silverstripe-framework#1 (travis-testing - f9c0bde : Simon Welsh): The build failed.
394: [08:25:00] <travis-ci> [travis-ci] Change view : https://github.com/simonwelsh/silverstripe-framework/compare/62753d861200...f9c0bde265c2
395: [08:25:00] <travis-ci> [travis-ci] Build details : http://travis-ci.org/simonwelsh/silverstripe-framework/builds/5619542
396: [08:28:00] * travis-ci has left #silverstripe
397: [08:28:00] * travis-ci has joined #silverstripe
398: [08:28:00] <travis-ci> [travis-ci] silverstripe/silverstripe-cms#285 (3.0 - 79c9d31 : Ingo Schommer): The build passed.
399: [08:28:00] * travis-ci has left #silverstripe
400: [08:28:00] <travis-ci> [travis-ci] Build details : http://travis-ci.org/silverstripe/silverstripe-cms/builds/5619539
401: [08:28:00] <travis-ci> [travis-ci] Change view : https://github.com/silverstripe/silverstripe-cms/compare/0f8d7a0aa4b6...79c9d3109947
402: [08:28:00] * travis-ci has joined #silverstripe
403: [08:28:00] <travis-ci> [travis-ci] simonwelsh/silverstripe-framework#2 (travis-testing - 57fb482 : Simon Welsh): The build is still failing.
404: [08:28:00] <travis-ci> [travis-ci] Change view : https://github.com/simonwelsh/silverstripe-framework/compare/f9c0bde265c2...57fb4823e24e
405: [08:28:00] <travis-ci> [travis-ci] Build details : http://travis-ci.org/simonwelsh/silverstripe-framework/builds/5619587
406: [08:30:00] <simon_w|air> Maybe I should turn IRC notifications off too
407: [08:30:00] <ajshort> simon_w|air: Clue: the sqlite3 directory is empty
408: [08:30:00] <ajshort> It's not a cache issue
409: [08:30:00] <simon_w|air> Hmm, it wasn't when I ran the exact same commands locally
410: [08:30:00] * travis-ci has joined #silverstripe
411: [08:30:00] <travis-ci> [travis-ci] silverstripe/silverstripe-cms#286 (3.1 - 75c77c4 : Ingo Schommer): The build passed.
412: [08:30:00] <travis-ci> [travis-ci] Change view : https://github.com/silverstripe/silverstripe-cms/compare/9bce2666394b...75c77c436193
413: [08:30:00] <travis-ci> [travis-ci] Build details : http://travis-ci.org/silverstripe/silverstripe-cms/builds/5619544
414: [08:30:00] * travis-ci has left #silverstripe
415: [08:31:00] <ajshort> simon_w|air: Yep, that's the problem :)
416: [08:31:00] <travis-ci> [travis-ci] Build details : http://travis-ci.org/simonwelsh/silverstripe-framework/builds/5619652
417: [08:31:00] * travis-ci has left #silverstripe
418: [08:31:00] <ajshort> You can also download a vagrant provisioned box from travis, which should be identical to the one travis runs
419: [08:31:00] <ajshort> and it works on that
420: [08:31:00] * travis-ci has joined #silverstripe
421: [08:31:00] <travis-ci> [travis-ci] simonwelsh/silverstripe-framework#3 (travis-testing - c308aba : Simon Welsh): The build has errored.
422: [08:31:00] <travis-ci> [travis-ci] Change view : https://github.com/simonwelsh/silverstripe-framework/compare/57fb4823e24e...c308aba7d4b4
423: [08:33:00] <travis-ci> [travis-ci] Change view : https://github.com/silverstripe/sapphire/compare/62753d861200...3abfc7e25c60
424: [08:33:00] <simon_w|air> Well, I've turned notifications off now
425: [08:33:00] * travis-ci has left #silverstripe
426: [08:33:00] * travis-ci has joined #silverstripe
427: [08:33:00] <travis-ci> [travis-ci] Build details : http://travis-ci.org/silverstripe/sapphire/builds/5619593
428: [08:33:00] <travis-ci> [travis-ci] silverstripe/sapphire#1682 (3.1 - 3abfc7e : Ingo Schommer): The build is still failing.
429: [08:36:00] <simon_w|air> and PHP needs less things that do exec()
430: [08:37:00] <ajshort> try ls sqlite3
431: [08:37:00] <ajshort> chillu: Time for the build to become super-super broken :)
432: [08:37:00] * pex__ has joined #silverstripe
433: [08:37:00] <ajshort> it gets the correct commit, but doesn't actually check it out properly
434: [08:37:00] <ajshort> simon_w|air: composer -v doesn't say anything useful
435: [08:38:00] <travis-ci> [travis-ci] Change view : https://github.com/ajshort/sapphire/compare/4e360201183f^...4836375a1fb3
436: [08:38:00] <ajshort> Hah
437: [08:38:00] <chillu> Goddammit ...
438: [08:38:00] * guci0 quit (Ping timeout: 245 seconds)
439: [08:38:00] * travis-ci has joined #silverstripe
440: [08:38:00] <travis-ci> [travis-ci] ajshort/sapphire#25 (3.1-deprecation-notification - 4836375 : Andrew Short): The build has errored.
441: [08:38:00] <travis-ci> [travis-ci] Build details : http://travis-ci.org/ajshort/sapphire/builds/5619702
442: [08:38:00] * travis-ci has left #silverstripe
443: [08:38:00] <ajshort> I think the build is too broken
444: [08:40:00] <ajshort> Yep, they limit the error log to 4MB
445: [08:40:00] <chillu> I'm looking into the deprecations now
446: [08:41:00] <travis-ci> [travis-ci] Build details : http://travis-ci.org/silverstripe/sapphire/builds/5619773
447: [08:41:00] * travis-ci has left #silverstripe
448: [08:41:00] * travis-ci has joined #silverstripe
449: [08:41:00] <travis-ci> [travis-ci] silverstripe/sapphire#1684 (3.1 - 888f32c : Ingo Schommer): The build has errored.
450: [08:41:00] <travis-ci> [travis-ci] Change view : https://github.com/silverstripe/sapphire/compare/3abfc7e25c60...888f32c6d125
451: [08:42:00] <simon_w|air> Can we at least move sqlite into allowed failures for now? // chillu
452: [08:43:00] <chillu> Yeah, I think that's necessary - can you send a PR with that?
453: [08:43:00] <simon_w|air> Sure. 3.0 and let you merge up?
454: [08:46:00] <travis-ci> [travis-ci] Change view : https://github.com/ajshort/sapphire/commit/31bf560254c6
455: [08:46:00] * travis-ci has left #silverstripe
456: [08:46:00] * travis-ci has joined #silverstripe
457: [08:46:00] <travis-ci> [travis-ci] ajshort/sapphire#26 (3.2-deprecation-notification - 31bf560 : Andrew Short): The build has errored.
458: [08:46:00] <travis-ci> [travis-ci] Build details : http://travis-ci.org/ajshort/sapphire/builds/5619831
459: [08:48:00] <simon_w|air> Ooh, only one line too long in 3.0
460: [08:48:00] <simon_w|air> No idea about the tabs though
461: [08:48:00] <ajshort> chillu: are you fine if I merge in the coding convention changes as well?
462: [08:49:00] <chillu> Three core members in agreement, I think the conventions can be updated. But we need to announce the change to the community.
463: [08:49:00] <simon_w|air> And then write more sniffs for them :)
464: [08:49:00] <travis-ci> [travis-ci] ajshort/sapphire#27 (3.2-deprecation-notification - 8dccaaa : Andrew Short): The build has errored.
465: [08:49:00] * travis-ci has joined #silverstripe
466: [08:49:00] * travis-ci has left #silverstripe
467: [08:49:00] <travis-ci> [travis-ci] Change view : https://github.com/ajshort/sapphire/compare/31bf560254c6...8dccaaaa6dab
468: [08:49:00] <travis-ci> [travis-ci] Build details : http://travis-ci.org/ajshort/sapphire/builds/5619897
469: [08:50:00] <travis-ci> [travis-ci] Build details : http://travis-ci.org/simonwelsh/silverstripe-framework/builds/5619914
470: [08:50:00] * travis-ci has left #silverstripe
471: [08:50:00] * travis-ci has joined #silverstripe
472: [08:50:00] <travis-ci> [travis-ci] simonwelsh/silverstripe-framework#7 (skip-sqlite - 2afa568 : Simon Welsh): The build passed.
473: [08:50:00] <travis-ci> [travis-ci] Change view : https://github.com/simonwelsh/silverstripe-framework/commit/2afa568d7e49
474: [08:51:00] <ajshort> simon_w|air: do you want to make an ss-dev post about the coding conventions?
475: [08:52:00] <simon_w|air> Yeah, I guess I could
476: [08:53:00] * travis-ci has joined #silverstripe
477: [08:53:00] <Bollig|DesignCty> ?
478: [08:53:00] <simon_w|air> Bollig|DesignCty, real estate? I do property (rentals) management
479: [08:53:00] * travis-ci has left #silverstripe
480: [08:53:00] <travis-ci> [travis-ci] Build details : http://travis-ci.org/simonwelsh/silverstripe-framework/builds/5619919
481: [08:53:00] <travis-ci> [travis-ci] Change view : https://github.com/simonwelsh/silverstripe-framework/compare/30c0f82221c4...15d325633a13
482: [08:53:00] <Bollig|DesignCty> hey simon, what was that realestate site you worked on
483: [08:53:00] <travis-ci> [travis-ci] simonwelsh/silverstripe-framework#8 (3.0 - 15d3256 : Andrew Short): The build failed.
484: [08:54:00] <Bollig|DesignCty> ah, pocket rent, nice
485: [08:54:00] <simon_w|air> and pocketrent.com
486: [08:56:00] <travis-ci> [travis-ci] Change view : https://github.com/silverstripe/sapphire/compare/15d325633a13...d36f9d69201b
487: [08:56:00] * travis-ci has joined #silverstripe
488: [08:56:00] <travis-ci> [travis-ci] silverstripe/sapphire#1687 (3.0 - d36f9d6 : Andrew Short): The build was fixed.
489: [08:56:00] <travis-ci> [travis-ci] Build details : http://travis-ci.org/silverstripe/sapphire/builds/5619983
490: [08:56:00] * travis-ci has left #silverstripe
491: [08:57:00] * ss23 cracks his knuckles
492: [08:57:00] <ss23> Look at open.silverstripe, sort by oldest first
493: [08:57:00] <ss23> Time to get started!
494: [09:00:00] * Bollig|DesignCty hugs ss23!
495: [09:01:00] <simon_w|air> ss23, a little
496: [09:01:00] <simon_w|air> chillu, something like http://pastebin.com/AfyiDEAT?
497: [09:01:00] <ss23> :D
498: [09:01:00] <chillu> simon_w|air: Given you kicked off the conventions changes, can you please post to the mailinglist about them?
499: [09:01:00] <ss23> Is the convention change something different to what's currently in http://doc.silverstripe.org/framework/en/trunk/misc/coding-conventions ?
500: [09:02:00] <chillu> Yep, sounds good
501: [09:02:00] <simon_w|air> Bah, stupid captcha. pastebin'll work now
502: [09:02:00] <ss23> simon_w|air: It's okay FYI, anyone can fill in the captcha on our end and see the paste
503: [09:03:00] <simon_w|air> Sweet. Should I wait for the merge (which'll also need to go into master before the docs update), or send now?
504: [09:04:00] * kinglozzer has joined #silverstripe
505: [09:04:00] <simon_w|air> Hmm, 10% battery left. I'll send before that dies
506: [09:05:00] <ss23> Still worth testing for BC
507: [09:05:00] <ss23> Is there a travis thing for testing it all works when magic_quotes are left on?
508: [09:05:00] <simon_w|air> ss23, magic_quotes are dead in 5.4. Kinda silly to test.
509: [09:06:00] <ss23> My thoughts are that if it's worth supporting a configuration where magic_quotes are on, then its worth testing that it works ;)
510: [09:06:00] * Zauberfisch has joined #silverstripe
511: [09:06:00] <simon_w|air> Deprecated in 5.3
512: [09:06:00] <simon_w|air> Not worth testing at all
513: [09:07:00] <simon_w|air> It's not worth supporting it :p
514: [09:07:00] <ss23> Want me to remove the support for it in latest branch, then?
515: [09:07:00] <simon_w|air> Just like safe_mode
516: [09:08:00] <ss23> lol
517: [09:08:00] <ss23> Probably is worth removing in 3.X, right?
518: [09:08:00] <simon_w|air> Sadly, there will be people effected by it
519: [09:08:00] <ss23> Then it's worth testing!
520: [09:08:00] <simon_w|air> Nope!
521: [09:08:00] <simon_w|air> They have broken servers!
522: [09:08:00] <simon_w|air> It's like IE6 :p
523: [09:09:00] <simon_w|air> ss23, everyone does
524: [09:09:00] <Zauberfisch> )
525: [09:09:00] <simon_w|air> Not worth testing, nice to know it maybe works
526: [09:09:00] <ss23> Is it okay to send a pull rqeuest for a bug fix with a branch name of patch-X
527: [09:09:00] <Zauberfisch> simon_w|air good changes
528: [09:09:00] <ss23> Hmm
529: [09:09:00] <ss23> I still think, if you're willing to support broken servers, you should be willing to test your support for them. In any case, I will make this pull reuqest
530: [09:09:00] <Zauberfisch> (dev list9
531: [09:10:00] <Zauberfisch> simon_w|air is it part of the coding conventions to not have ?>
532: [09:10:00] <Zauberfisch> good
533: [09:10:00] <Bollig|DesignCty> YOUR FACE DECREASES PRODUCTIVITY
534: [09:10:00] <ss23> tbh, if theres a bug that hasn't been touched for more than 2 months, something needs to be done about it!
535: [09:10:00] <simon_w|air> http://doc.silverstripe.org/framework/en/trunk/misc/coding-conventions#php-code-declaration
536: [09:10:00] <ss23> Bollig|DesignCty: I'm cleaning up the bug tracker. A messy bug tracker decreases producitity
537: [09:10:00] <Bollig|DesignCty> perhaps the better way to look at it ss23 is that's it's not that it shouldn't be done, but it's a lower priority. There are more important things you could be writing tests for, or...?
538: [09:10:00] <ss23> Sweet
539: [09:10:00] <simon_w|air> Zauberfisch, yup
540: [09:10:00] <Zauberfisch> if not we should add that as well
541: [09:11:00] <Bollig|DesignCty> sorry... ;)
542: [09:11:00] * simon_w|air high-fives Bollig|DesignCty
543: [09:13:00] <Bollig|DesignCty> lol
544: [09:13:00] * ss23 cries
545: [09:13:00] <ss23> Bollig|DesignCty: OUCH
546: [09:13:00] <ss23> :<
547: [09:13:00] <Bollig|DesignCty> school must have been difficult with such thin skin...
548: [09:13:00] <Bollig|DesignCty> :D
549: [09:13:00] <ss23> lol
550: [09:13:00] <ss23> Does the person who accepts a pull request close the bug on open.silverstripe too?
551: [09:14:00] <simon_w|air> If you reference, they should
552: [09:14:00] <chillu> Usually, although its up to the submitter to verify
553: [09:15:00] <Zauberfisch^idle> haha, then you can take that as a no ss23
554: [09:15:00] * Zauberfisch quit (Ping timeout: 245 seconds)
555: [09:15:00] <Zauberfisch^idle> when I write bugfixes I don't even bother to look if theres a ticket in the tracker
556: [09:15:00] <ss23> chillu: I'm working on *old* bugs (this one is over 2 years old)
557: [09:15:00] <chillu> ss23: Thanks for helping us with bug triage! So you're closing bugs you can no longer reproduce, or that have been fixed in a newer release in the meantime, right?
558: [09:16:00] <ss23> chillu: This one was a valid bug that had just been missed and not pulled in, but I'm going to look at all of the (easy) bugs that I can and figure something out
559: [09:17:00] <chillu> Awesome
560: [09:17:00] <ss23> Speaking of, chillu ;)
561: [09:17:00] <ss23> chillu: http://open.silverstripe.org/ticket/4734 Status? The pull request has been closed
562: [09:17:00] <ss23> (You're on it, 11 months old)
563: [09:18:00] <chillu> Too much context for me to process at the moment, I'm busy fixing deprecation stuff
564: [09:18:00] <ss23> kk, np
565: [09:19:00] <Zauberfisch^idle> ss23 awesome
566: [09:19:00] <Zauberfisch^idle> this is a great idea
567: [09:19:00] <Zauberfisch^idle> keep on going
568: [09:22:00] <ss23> dammit
569: [09:23:00] <ss23> :<
570: [09:23:00] * ss23 looks at simon_w|air
571: [09:23:00] <simon_w|air> ss23, ask someone with access very nicely to change it for you
572: [09:23:00] <ss23> I signed up to open.silverstripe on an old work email :<
573: [09:23:00] <chillu> And simon_w|air, I'll give you admin access
574: [09:23:00] <chillu> ss23 I can change it for you
575: [09:23:00] <simon_w|air> (I don't have access)
576: [09:24:00] <simon_w|air> ss23, anyone can close bugs!
577: [09:24:00] <ss23> chillu: ty, username :ss23, email should be ss23@digicreative (but if its not, let me know, it might be an email I do have access to)
578: [09:24:00] <ss23> Yeah, was going to say, if simon can accept pulls, but no access on open.ss, how can he close bugs!
579: [09:24:00] * Zauberfisch has joined #silverstripe
580: [09:25:00] <ss23> Oh, cool!
581: [09:25:00] <ss23> simon_w|air: I wasn't sure, thats why I was going to login and see if I could close :P
582: [09:25:00] <chillu> I guess that's ss23@digicreative.com?
583: [09:25:00] * peter_ss quit (Quit: Leaving.)
584: [09:25:00] * Shrike_Finland has joined #silverstripe
585: [09:25:00] <simon_w|air> chillu, sweet.
586: [09:26:00] <ss23> XD
587: [09:26:00] <chillu> Lol I actually hvae to remove the existing user to change the email. Good ol' Trac
588: [09:26:00] <ss23> chillu: Username definitly "ss23" though, but not 100% on the email, I don't seem to have any emails from silverstripe about it in my normal inbox, hence why I suspect it was under my old worl email
589: [09:26:00] <ss23> chillu: ss23@digicreative.co.nz, probably
590: [09:27:00] <ss23> chillu: If you can just reset password, I can probably change it myself (if thats allowed in trac)
591: [09:27:00] <Zauberfisch> github issues are nice
592: [09:27:00] <simon_w|air> Eww, github issues
593: [09:27:00] <Zauberfisch^idle> I hate trac
594: [09:27:00] <Zauberfisch^idle> github issues ftw
595: [09:27:00] <ss23> Yeah, github is nice
596: [09:27:00] <chillu> Seems so arcane now that there's github et al
597: [09:27:00] <ss23> Whatever is easiest for you though!
598: [09:28:00] <simon_w|air> github issues are horribly underpowered :p
599: [09:28:00] <simon_w|air> Doesn't stop it being true :p
600: [09:28:00] <chillu> simon_w|air is such a git* hater ;)
601: [09:28:00] <Zauberfisch> be quiet simon
602: [09:28:00] <chillu> Yeah, we considered migrating, its just a matter of time investment really
603: [09:29:00] <Zauberfisch> <3
604: [09:29:00] <Zauberfisch> chillu really?
605: [09:29:00] <Zauberfisch> you did consider it?
606: [09:29:00] <chillu> Alright simon_w|air ajshort you're Trac admins now
607: [09:29:00] <Zauberfisch> and its just about the time?
608: [09:30:00] <ajshort> why?
609: [09:30:00] * waveydave has joined #silverstripe
610: [09:30:00] <Zauberfisch> crap
611: [09:30:00] <Zauberfisch> 1278 open tickets
612: [09:30:00] <chillu> We'd need to evaluate how many issues github can handle effectively, and then make some hard calls on which ones we port over. For now its just a 10 min conversation I had with Sam a while ago
613: [09:30:00] <ajshort> yay!
614: [09:31:00] * ss23 closes a ticket!
615: [09:31:00] <simon_w|air> ss23, yay!
616: [09:31:00] <simon_w|air> https://github.com/composer/composer/issues has 218, and is showing the lack of scale
617: [09:31:00] <ss23> Well, regardless of which tracker you use, having open tickets that should be closed is bad!
618: [09:31:00] <Zauberfisch> migrating that could actually mean some work
619: [09:31:00] <simon_w|air> Especially since submitters can't even tag things
620: [09:32:00] <ss23> Status changed from new to closed
621: [09:32:00] <ss23> Resolution set to fixed
622: [09:32:00] <ss23> BOOM
623: [09:33:00] <chillu> ss23: OK, one down, 1277 to go ;)
624: [09:33:00] <ss23> XD
625: [09:33:00] * lx-berlin has joined #silverstripe
626: [09:34:00] <ss23> This is the second one, actually! The first is just waiting on someone to accept the pull request (*cough* simon_w|air, since you love magic_quotes so much)
627: [09:34:00] <simon_w|air> Fine, I'll go look at it :p
628: [09:35:00] * ss23 claps
629: [09:35:00] <ss23> :D
630: [09:36:00] <ss23> simon_w|air: Want me to close the bug?
631: [09:36:00] <ss23> oh cool, thats fine!
632: [09:36:00] <ss23> YAY!
633: [09:36:00] <ss23> 2 down :D
634: [09:36:00] <ss23> Come on, Zauberfisch^idle, Bollig|DesignCty! Join me!
635: [09:37:00] <ss23> nn simon_w|air~
636: [09:37:00] <simon_w|air> And I'm going to go sleep!
637: [09:37:00] <ss23> TOGETHER WE'LL CLOSE ALL 1.2k!
638: [09:38:00] <ss23> I dreamt of Silverstipre all last night
639: [09:38:00] <ss23> Someone dleted a silverstripe module and I had to recreate it and I kept thinking "WHY WASN'T THIS MODULE IN GIT"
640: [09:38:00] <simon_w|air> That's what you get for actually having dreams (at night time)
641: [09:38:00] <ss23> Horrible dreams >.<
642: [09:38:00] <ss23> ik :<
643: [09:40:00] <ss23> There's always time!
644: [09:40:00] <Zauberfisch> but besides that there is no time
645: [09:40:00] <Zauberfisch> ss23 as a matter of fact I am actually going to fix a bug now
646: [09:40:00] <Zauberfisch> haha
647: [09:40:00] * priithansen has joined #silverstripe
648: [09:41:00] <ss23> If everyone here closed one old bug a night, it would be done in... well... a while!
649: [09:42:00] <travis-ci> [travis-ci] Build details : http://travis-ci.org/silverstripe/sapphire/builds/5620644
650: [09:42:00] * waveydave quit (Ping timeout: 272 seconds)
651: [09:42:00] * travis-ci has joined #silverstripe
652: [09:42:00] <travis-ci> [travis-ci] silverstripe/sapphire#1689 (3.0 - 00bcdf3 : Simon Welsh): The build passed.
653: [09:42:00] <travis-ci> [travis-ci] Change view : https://github.com/silverstripe/sapphire/compare/d36f9d69201b...00bcdf39d3ce
654: [09:42:00] * travis-ci has left #silverstripe
655: [09:45:00] <travis-ci> [travis-ci] Change view : https://github.com/silverstripe/sapphire/compare/888f32c6d125...8629985115f4
656: [09:45:00] * travis-ci has left #silverstripe
657: [09:45:00] <travis-ci> [travis-ci] Build details : http://travis-ci.org/silverstripe/sapphire/builds/5620715
658: [09:45:00] <travis-ci> [travis-ci] silverstripe/sapphire#1690 (3.1 - 8629985 : Ingo Schommer): The build failed.
659: [09:45:00] * travis-ci has joined #silverstripe
660: [09:46:00] * CHIex has joined #silverstripe
661: [09:51:00] * lx-berlin has left #silverstripe
662: [09:53:00] * LoveDuckie quit (Ping timeout: 245 seconds)
663: [09:53:00] * LoveDuckie has joined #silverstripe
664: [09:54:00] <ocm> gooodmorning!
665: [09:54:00] * ocm has joined #silverstripe
666: [09:54:00] <ss23> moin moin, ocm
667: [09:55:00] <ss23> Whats the status on new features for the 2.X branch?
668: [09:56:00] <ss23> (bzz ajshort chillu ^)
669: [09:58:00] <ss23> Sweet
670: [09:58:00] <ajshort> ss23: 2.x is for important bugfixes only
671: [09:58:00] <chillu> We have post-2.4 (aka 2.5) for that, but only quite conservatively. Its mostly for bugfixing
672: [10:00:00] <ocm> did 2.4 get any new updates aftger 2.4.9?
673: [10:02:00] <ajshort> there's a 2.4.10
674: [10:04:00] <ss23> A bug being in status infoneeded_new for more than 6 months is a good reason to close it with a message to submit/reopen if it's still an issue, right?
675: [10:05:00] * ss23 becomes crazy closer of bugs!
676: [10:05:00] <chillu> Yeah absolutely. I would even say a month without a reply on infoneeded is a good indicator the ticket should be closed (unless it has a lot of backstory)
677: [10:05:00] <ss23> sweeeet
678: [10:06:00] <g4b0> hi all
679: [10:06:00] * g4b0 has joined #silverstripe
680: [10:07:00] <ss23> Grr, have to "provide info" and then close it... I hate trac.
681: [10:07:00] <ocm> heya g4b0
682: [10:08:00] * Shrike_Finland quit (Quit: Leaving.)
683: [10:09:00] <chillu> Yeah, that's actually our #fail for setting up the workflow wrong, but I can't be bothered figuring out the right config
684: [10:10:00] <ss23> yeah np, I can easily get around it
685: [10:19:00] * Guest17211 has joined #silverstripe
686: [10:19:00] * mrzero quit (Ping timeout: 255 seconds)
687: [10:19:00] * ec8or quit (Ping timeout: 260 seconds)
688: [10:19:00] * Zauberfisch quit (Ping timeout: 256 seconds)
689: [10:19:00] * ajshort quit (Ping timeout: 260 seconds)
690: [10:19:00] * discorpia quit (Ping timeout: 260 seconds)
691: [10:20:00] * mrzero_ has joined #silverstripe
692: [10:20:00] * mrzero_ is now known as mrzero
693: [10:20:00] * discorpia has joined #silverstripe
694: [10:20:00] * mrzero_ has joined #silverstripe
695: [10:20:00] * mrzero_ quit (Changing host)
696: [10:20:00] * ec8or_ has joined #silverstripe
697: [10:21:00] <g4b0> but I've got no idea where to start :)
698: [10:21:00] <g4b0> I would like to work on http://open.silverstripe.org/ticket/8310
699: [10:21:00] <g4b0> and http://open.silverstripe.org/ticket/8327 (duplicate?)
700: [10:21:00] <g4b0> any hint?
701: [10:22:00] <ss23> g4b0: Looks strange. If a reload fixes them, does the network tab show anything interesting, like a failing request etc?
702: [10:23:00] <g4b0> let's have a check
703: [10:23:00] <g4b0> mmm never looked at the network tab
704: [10:24:00] <chillu> g4b0: Have a look if there's any differences in the value of the ssTinyMceConfig JS global var when loading with/without ajax. And try it with HTMLEditorField.use_gzip = false (in your YAML config)
705: [10:25:00] <g4b0> ok
706: [10:27:00] * Pigeon has joined #silverstripe
707: [10:27:00] * Pigeon is now known as Guest99229
708: [10:28:00] * Guest17211 is now known as ajshort_
709: [10:29:00] * Guest99229 is now known as PigeonFriend
710: [10:30:00] * lx-berlin has joined #silverstripe
711: [10:31:00] <ss23> 7 bugs closed tonight
712: [10:31:00] <ss23> I'm on a roll, baby.
713: [10:31:00] * ss23 flxes
714: [10:32:00] <travis-ci> [travis-ci] Change view : https://github.com/silverstripe/sapphire/compare/8629985115f4...b282c9f8f3af
715: [10:32:00] * travis-ci has left #silverstripe
716: [10:32:00] * travis-ci has joined #silverstripe
717: [10:32:00] <travis-ci> [travis-ci] silverstripe/sapphire#1691 (3.1 - b282c9f : Ingo Schommer): The build is still failing.
718: [10:32:00] <travis-ci> [travis-ci] Build details : http://travis-ci.org/silverstripe/sapphire/builds/5621561
719: [10:35:00] * C10ne has joined #silverstripe
720: [10:35:00] <g4b0> it's not a flush=all question
721: [10:35:00] <g4b0> chillu: you're right
722: [10:36:00] <g4b0> of re-adding the button
723: [10:36:00] <ajshort_> chillu: BTW, I've updated my HTTP pull request, it's at a state where I'm happy with it
724: [10:36:00] <g4b0> just reloading the page does the trick
725: [10:36:00] <g4b0> so it's an AJAX problem
726: [10:37:00] <chillu> Awesome. I'll try to squash more immediate fires at the moment, but its in the email backlog for me ;)
727: [10:38:00] <ajshort_> yep cool
728: [10:44:00] * zfmf has left #silverstripe
729: [10:46:00] <ss23> PigeonFriend: Aha, was that your bug?
730: [10:46:00] <PigeonFriend> ss23: whoop, you fixed the $_COOKIES magic quotes issue. at long last :P
731: [10:47:00] <ss23> XD
732: [10:47:00] <ss23> PigeonFriend: I'm going through all the old bugs I can find and easily close / fix
733: [10:47:00] * zfmf has joined #silverstripe
734: [10:47:00] * MrGuits quit (Ping timeout: 252 seconds)
735: [10:47:00] <PigeonFriend> good man
736: [10:47:00] <PigeonFriend> yre. looking at it now, i have no idea why i didnt patch that myself
737: [10:48:00] <ss23> PigeonFriend: If I have to spend more than 3 mins tracking down information on/for a bug report, I close it and go to the next one :P
738: [10:48:00] <PigeonFriend> I've reported a few not-so-easy bugs, you can try those if you like ;)
739: [10:48:00] <ss23> Aha, don't think so
740: [10:50:00] <ss23> If I close 10 bugs a night, it'll take me less than a year to close every bug on the tracker! YAY!
741: [10:50:00] <ss23> If it involves more than a one line patch, I don't wanna do it!
742: [10:50:00] <ss23> PigeonFriend: 10 closed so far! feel free to join me if you wanna close some easy bugs and clean up the tracker
743: [10:50:00] <PigeonFriend> ss23: I have a few un reported bugs im going to work on
744: [10:50:00] <PigeonFriend> oh, an easy one for you
745: [10:51:00] <PigeonFriend> it is one line... ok, 3, but thats not much
746: [10:51:00] <PigeonFriend> BulkCsvLoader (i think that's the class) doesn't have a preview function, which it should. and all it needs to do is call loadAll($file, true);
747: [10:52:00] <ss23> lol, you'll be quicker to write that one, PigeonFriend.
748: [10:52:00] <ss23> I'm just fixing up the bugs that I can do without context / knowledge etc
749: [10:52:00] <PigeonFriend> another issue with it is it doesn't check the encoding of the file is UTF-8
750: [10:52:00] <PigeonFriend> ss23, ok ok
751: [10:52:00] <PigeonFriend> which can cause a ton of problems
752: [10:58:00] * pex__ has left #silverstripe
753: [10:59:00] <g4b0> chillu: searching for TinyMCE issue I found another one: http://open.silverstripe.org/ticket/8330
754: [10:59:00] <g4b0> I think it's convenient to add it to 3.1.0-rc1 branch, isn't it?
755: [11:00:00] <g4b0> you can test it just reloading a page bypassing AJAX in dev mode
756: [11:00:00] <ajshort_> PigeonFriend: @inheritDoc is your friend :)
757: [11:01:00] <PigeonFriend> ajshort_: cheers
758: [11:02:00] <ss23> 12 bugs closed! ha ha ha ha ha
759: [11:02:00] * peter_ss has joined #silverstripe
760: [11:02:00] <PigeonFriend> ajshort_: other thought on that commit is that the $preview flag isn't taken into account for the relationships part of processAll()... I'm thinking of just skipping it if we preview... yay, or nay?
761: [11:02:00] <ajshort_> it's probably acceptable i would think
762: [11:03:00] <ajshort_> super-ideally something might happen with UnsavedRelationList, but w/e
763: [11:03:00] <ajshort_> ok
764: [11:03:00] <PigeonFriend> ajshort_: I'm doing it at 3.0 level, so that'd need to be specific to 3.1
765: [11:03:00] <ajshort_> but thats just my 5c
766: [11:04:00] <ajshort_> just keep in mind active development should me transitioning to 3.1/3.2
767: [11:04:00] <ajshort_> it'll probably be accepted, since it's pretty minor
768: [11:06:00] <PigeonFriend> ajshort_: sure, I don't tend to submit to 3.0 anymore, but i feel kind of bad leaving them out! I've also got a 3.0 site that I want to maintain and don't want to upgrade due to some deprecated classes/methods we're relying on... screw re-writing them! ;)
769: [11:07:00] <PigeonFriend> ss23 yep, master is 3.2 i believe
770: [11:07:00] <ss23> there's no branch for 3.2, I take it new code dev stuff is meant to be done on master then?
771: [11:08:00] <ss23> I suspect this patch will break everything. TRAVIS HAVE MERCY, TELL ME IF IT WILL
772: [11:14:00] * CHIex quit (Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/)
773: [11:15:00] <ajshort_> ss23: that would require a unit test
774: [11:16:00] <ss23> People have written lots of tests for Silverstripe, right?
775: [11:16:00] <g4b0> How can I set HTMLEditorField.use_gzip = false in my YAML config?
776: [11:16:00] <ss23> ajshort_: I'm hoping that someone already wrote a unit test that covers this stuf... thats a sane hope, right? Right?
777: [11:16:00] <ajshort_> ideally a bug fix would come with a failing unit test that it fixes
778: [11:16:00] <ajshort_> if there's no failing test at the moment, then no test covers it
779: [11:17:00] <ss23> Yeah, I know what you mean, ajshort_, but I'm more worried about whether this patch *breaks* things :P
780: [11:17:00] <ss23> ajshort_: It's not my patch anyway, I just want to get the bug closed.
781: [11:17:00] <ajshort_> you need a unit test that demonstrates what issue is being fixes
782: [11:17:00] <ajshort_> that's my commend
783: [11:17:00] <ss23> ajshort_: I'm also relying on the person who views the pull request!
784: [11:17:00] <ajshort_> it's not enough just to rely on the existing tests
785: [11:17:00] <g4b0> I'm a YAML newbe :)
786: [11:18:00] <ajshort_> why not just leave it open?
787: [11:18:00] <ajshort_> you can't really expect an old test you haven't tested at all with no unit tests to be merged in
788: [11:18:00] <ss23> ajshort_: Because its TWO YEARS OLD
789: [11:19:00] <ajshort_> it's in a very important piece of code
790: [11:19:00] <ss23> ajshort_: It's a tiny change though
791: [11:19:00] <ss23> ajshort_: I don't wanna leave it open. a 2 year old bug is bad ;_;
792: [11:19:00] <ajshort_> just leave it open :)
793: [11:21:00] <ajshort_> it sounds pretty quiet from here :P
794: [11:21:00] <C10ne> If anybody needs this, batch translate for SS 3.0.5 http://www.sspaste.com/paste/show/51484887b428a
795: [11:21:00] <ss23> ajshort_: I can close if you want, but I don't wanna leave a 2 year old bug unattended. Look at it, it's in dire need of attention. It's screaming and yelling.
796: [11:22:00] <ss23> ajshort_: You just have your earplugs in...
797: [11:23:00] <g4b0> chillu: putting HTMLEditorField.use_gzip = false solve http://open.silverstripe.org/ticket/8327
798: [11:26:00] <g4b0> it's just a workaround
799: [11:26:00] <chillu> g4b0: It just narrows down the problem :)
800: [11:26:00] <g4b0> I know
801: [11:27:00] <g4b0> as I wrote into the comments :)
802: [11:27:00] <ss23> PigeonFriend: You're doing work on CsvBulkLoader right?
803: [11:28:00] <PigeonFriend> ss23: yep: https://github.com/silverstripe/sapphire/pull/1306
804: [11:28:00] <ss23> PigeonFriend: http://open.silverstripe.org/ticket/6227 Thoughts on that?
805: [11:28:00] <g4b0> but also a good starting point for killing the bug!
806: [11:30:00] * g4b0 quit (Quit: Sto andando via)
807: [11:30:00] <ss23> PigeonFriend: http://open.silverstripe.org/ticket/6255 Another csvbulkloader bug! :D
808: [11:31:00] <PigeonFriend> ss23: #6227 yes, i noticed that the other day, actually, forgot about it. pretty massive security flaw there
809: [11:31:00] <PigeonFriend> needs a fix#
810: [11:32:00] <ss23> PigeonFriend: Want me to submit a pull request with that patch then? It looks trivial
811: [11:32:00] <PigeonFriend> ss23: #6255 that needs discussion with core team, i think
812: [11:32:00] <PigeonFriend> ss23: it is trivial, do it
813: [11:32:00] <ss23> Yeah, 6255 seemed more complex, but thought I would link to you since you know more than me about it
814: [11:33:00] <PigeonFriend> I'd also do it for all versions of SS from 2.3 up (if this is a weakness in those versions) as it is a big whole
815: [11:33:00] <PigeonFriend> *hole
816: [11:34:00] <ss23> Whats the protocol on that? Make one pull request and let the person who accepts it cherrypick (or wahtever its called in git) it into the required branches?
817: [11:34:00] <PigeonFriend> ss23: I believe you put it into the lowest branch that it effects and then, yes, they'll cherry pick it into the newer ones. @chillu: that right?
818: [11:34:00] <PigeonFriend> #6255 i think makes sense, but it is a change to expected behaviour
819: [11:35:00] <ss23> 2.4 is the lowest for security fixes, right?
820: [11:36:00] <travis-ci> [travis-ci] Build details : http://travis-ci.org/ajshort/sapphire/builds/5622755
821: [11:36:00] <PigeonFriend> ss23: I'm not sure. I still have 2.3 sites i need to support ;)
822: [11:36:00] * travis-ci has left #silverstripe
823: [11:36:00] * travis-ci has joined #silverstripe
824: [11:36:00] <travis-ci> [travis-ci] Change view : https://github.com/ajshort/sapphire/compare/6ae931df249a...b8a51c379231
825: [11:36:00] <travis-ci> [travis-ci] ajshort/sapphire#28 (3.1 - b8a51c3 : Andrew Short): The build is still failing.
826: [11:37:00] * Bollig|DesignCty quit (Quit: Bollig|DesignCty)
827: [11:37:00] <ajshort_> affected ones
828: [11:37:00] <ajshort_> no
829: [11:37:00] <ss23> ajshort_: A seperate pull request for every branch?
830: [11:37:00] <ss23> ajshort_ ^^ what branch for security fixes?
831: [11:38:00] <ss23> ajshort_: This bug is from 2.1 up to master
832: [11:38:00] <ajshort_> heh
833: [11:38:00] <ss23> So I'm not sure which to file it under
834: [11:38:00] <ajshort_> i'm not too sure then
835: [11:38:00] * Bollig|DesignCty has joined #silverstripe
836: [11:38:00] * Bollig|DesignCty quit (Client Quit)
837: [11:38:00] <ss23> Hmm
838: [11:38:00] <ss23> I'll file it under 3.0 and let the person who reads it deal with it? Probably better to file than not since it's security, right?
839: [11:38:00] <ss23> Or chillu if chillu is here...
840: [11:38:00] <ajshort_> 3.0 is merged into 3.1, which is merged into master
841: [11:39:00] * ss23 pokes chillu
842: [11:40:00] * travis-ci has left #silverstripe
843: [11:40:00] <travis-ci> [travis-ci] Build details : http://travis-ci.org/silverstripe/sapphire/builds/5622892
844: [11:40:00] <travis-ci> [travis-ci] Change view : https://github.com/silverstripe/sapphire/compare/b282c9f8f3af...b8a51c379231
845: [11:40:00] <travis-ci> [travis-ci] silverstripe/sapphire#1697 (3.1 - b8a51c3 : Andrew Short): The build is still failing.
846: [11:40:00] * travis-ci has joined #silverstripe
847: [11:41:00] <chillu> ajshort_: 2.3 is no longer maintained, so file it under 2.4
848: [11:41:00] <chillu> I mean, ss23
849: [11:41:00] <ss23> k, will do that (assume that was @ me)
850: [11:42:00] <travis-ci> [travis-ci] Change view : https://github.com/ajshort/sapphire/compare/bc941c18b60f...94f209eb745f
851: [11:42:00] * travis-ci has joined #silverstripe
852: [11:42:00] <PigeonFriend> chillu: 2.3 not maintained even for SQL injection vulnerability?
853: [11:42:00] * travis-ci has left #silverstripe
854: [11:42:00] * silverseba has joined #silverstripe
855: [11:42:00] <travis-ci> [travis-ci] Build details : http://travis-ci.org/ajshort/sapphire/builds/5622909
856: [11:42:00] <travis-ci> [travis-ci] ajshort/sapphire#29 (master - 94f209e : Andrew Short): The build is still failing.
857: [11:43:00] <chillu> http://doc.silverstripe.org/framework/en/trunk/misc/release-process#supported-versions
858: [11:43:00] <ss23> PigeonFriend: Sounds like a good chance to upgrade!
859: [11:44:00] <PigeonFriend> chillu: ok :( Also, looks like the deprecation docs need updating (heading below that)
860: [11:45:00] <chillu> :D
861: [11:45:00] * PigeonFriend shakes fist at chillu! you sly fox
862: [11:45:00] <chillu> Oh yep, they should use Deprecation::notice(). Feel free to PR ;)
863: [11:46:00] <PigeonFriend> i'm not sure which i dislike more: writing tests or writing docs
864: [11:46:00] <ss23> PigeonFriend: Tests by far!
865: [11:52:00] * Bollig|DesignCty has joined #silverstripe
866: [11:57:00] * Shrike_Finland has joined #silverstripe
867: [11:59:00] * Guits has joined #silverstripe
868: [12:01:00] * UndefinedOffset has joined #silverstripe
869: [12:04:00] <travis-ci> [travis-ci] Build details : http://travis-ci.org/silverstripe/sapphire/builds/5623322
870: [12:04:00] <travis-ci> [travis-ci] Change view : https://github.com/silverstripe/sapphire/compare/b8a51c379231...8538cb9ee202
871: [12:04:00] <travis-ci> [travis-ci] silverstripe/sapphire#1699 (3.1 - 8538cb9 : Ingo Schommer): The build was fixed.
872: [12:04:00] * travis-ci has joined #silverstripe
873: [12:04:00] * travis-ci has left #silverstripe
874: [12:04:00] <ss23> Yay!
875: [12:04:00] <chillu> woop woop!
876: [12:09:00] <ss23> PigeonFriend: Ah, I found one of your hard bugs. I'm going to leave it ;_;
877: [12:10:00] <PigeonFriend> ss23: which one? lazyloading issues?
878: [12:11:00] <ss23> PigeonFriend: http://open.silverstripe.org/ticket/6458
879: [12:11:00] <chillu> ss23: regarding https://github.com/silverstripe/sapphire/pull/1307 - please ensure that info is cross referenced from both "sides", so add a comment on trac that this PR exists.
880: [12:12:00] <travis-ci> [travis-ci] Change view : https://github.com/silverstripe/sapphire/compare/bc941c18b60f...94f209eb745f
881: [12:12:00] * travis-ci has left #silverstripe
882: [12:12:00] <chillu> Then, I think having PRs without a real owner is harmful, since it puts the responsibility for getting it tested essentially on the core team.
883: [12:12:00] <PigeonFriend> ss23: i think that issue has actually been fixed
884: [12:12:00] <PigeonFriend> and quite some time ago too
885: [12:12:00] <ss23> chillu: Want me to close and ask the submitter for a unit test etc?
886: [12:12:00] <travis-ci> [travis-ci] silverstripe/sapphire#1701 (master - 94f209e : Andrew Short): The build is still failing.
887: [12:12:00] * travis-ci has joined #silverstripe
888: [12:12:00] <ss23> chillu: Okay, will do. Wasn't sure where you wanted discussion to take place
889: [12:12:00] * priithansen_ has joined #silverstripe
890: [12:12:00] <travis-ci> [travis-ci] Build details : http://travis-ci.org/silverstripe/sapphire/builds/5623476
891: [12:13:00] <ss23> chillu: kk, will do
892: [12:13:00] <PigeonFriend> tut-tut, fair weather contributor ;)
893: [12:13:00] <PigeonFriend> ss23: write the test!
894: [12:13:00] <chillu> So standard process should be to ask the original submitter to file a PR instead of attaching a patch. It'd be nice if you can verify the fix and "own" it going forward as well, but no ownerless PRs please
895: [12:13:00] <PigeonFriend> come on, it's a simple one ;)
896: [12:13:00] <ss23> PigeonFriend: I don't think so!
897: [12:13:00] <ss23> PigeonFriend: Eh, it's simple patch, not simple change :P
898: [12:14:00] <PigeonFriend> chillu: this bug was fixed long ago, no? http://open.silverstripe.org/ticket/6458
899: [12:14:00] * priithansen_ is now known as priithansen
900: [12:14:00] * priithansen quit (Ping timeout: 264 seconds)
901: [12:14:00] <travis-ci> [travis-ci] silverstripe/sapphire#1700 (2.4 - 5cad7fe : Ingo Schommer): The build passed.
902: [12:14:00] <travis-ci> [travis-ci] Change view : https://github.com/silverstripe/sapphire/compare/a8a10f8a1a55...5cad7fe9e345
903: [12:14:00] <travis-ci> [travis-ci] Build details : http://travis-ci.org/silverstripe/sapphire/builds/5623429
904: [12:14:00] * travis-ci has left #silverstripe
905: [12:14:00] * travis-ci has joined #silverstripe
906: [12:14:00] <PigeonFriend> because all SQL statements have an if statement in the select for RecordClass.. i believe
907: [12:15:00] <PigeonFriend> chillu: stop with your fancy language.
908: [12:15:00] <chillu> I'd think so, should be an easy smoke test to do, right?
909: [12:15:00] <PigeonFriend> "CASE WHEN "SiteTree"."ClassName" IS NOT NULL THEN "SiteTree"."ClassName" ELSE 'SiteTree' END AS "RecordClassName" " is what i see in the queries
910: [12:16:00] <chillu> No smoking in here?
911: [12:16:00] <ss23> lol
912: [12:16:00] * PigeonFriend wikipedia... smoke test... http://en.wikipedia.org/wiki/Smoke_testing
913: [12:16:00] <ss23> Almost .01% of all the bugs!
914: [12:16:00] <chillu> "Smoke testing refers to physical tests made to closed systems of pipes to test for leaks" - ah, the pipes.
915: [12:16:00] <ss23> When you guys figure out that this is fixed, I'm totally chalking it up as another close on my behalf! This is like almost 20 tonight!
916: [12:16:00] * silverseba quit (Quit: Page closed)
917: [12:16:00] <chillu> ss23: Awesome!
918: [12:17:00] <PigeonFriend> chillu: that case statement is a fix to my ticket. basically, what was happening was if you removed a class during dev, ran a dev/build it'd cause all DB rows with that class to become null (or empty) for the ClassName field.
919: [12:17:00] * ARNHOE has joined #silverstripe
920: [12:18:00] <ss23> idek how to tell ,it doesn't display username or email >.<
921: [12:18:00] <PigeonFriend> so that condition stops it happening
922: [12:18:00] <ss23> Simon on the bugtracker is simon_w, right?
923: [12:19:00] * ARNHOE quit (Remote host closed the connection)
924: [12:20:00] * Zauberfisch has joined #silverstripe
925: [12:20:00] * Guits quit (Ping timeout: 264 seconds)
926: [12:20:00] <chillu> Yeah. Trac = blergh. Github = yay
927: [12:20:00] * ARNHOE has joined #silverstripe
928: [12:20:00] <ss23> Ah, I see
929: [12:20:00] <chillu> ss23: We used to have a "Simon" as the first SS Ltd. employee, so simon_w is simon_w really
930: [12:20:00] <chillu> (displays usernames in context)
931: [12:22:00] <ss23> chillu: That pull request I made btw, the sqli one, that was for all branches you know right? Effects 2.4 and up to trunk
932: [12:23:00] <ss23> chillu: https://github.com/silverstripe/sapphire/pull/1308
933: [12:23:00] <chillu> URL?
934: [12:24:00] <PigeonFriend> @chillu: affects them all!
935: [12:24:00] <chillu> Yeah, I'll merge the changes through now
936: [12:24:00] <ss23> I hope you're not making fun of my effects/affects! I can never remember which to use >.<
937: [12:25:00] <PigeonFriend> ss23: I think im wrong in this context, tbh
938: [12:25:00] <PigeonFriend> I can't ever remember either
939: [12:26:00] <PigeonFriend> something like that
940: [12:26:00] <ss23> The effects of the patch affect them all
941: [12:27:00] <chillu> I'll cherrypick the PR from above into 2.3
942: [12:27:00] <chillu> PigeonFriend: 2.3 maintenance is on a best-effort basis. I agree that straightforward security fixes should find their way into 2.3, regardless if the release is marked unmaintained.
943: [12:28:00] <chillu> But in general, our time is limited, so we have to a) limit the amount of maintained codebases and b) avoid breaking legacy codebases with intrusive changes
944: [12:29:00] <PigeonFriend> chillu: agree, I do still support a few 2.3 sites. so I'm happy to provide some time to that if required.
945: [12:30:00] <chillu> Maybe go through the recent security announcements and see if there's any omissions and/or easy backports?
946: [12:30:00] <ss23> I was just like "sounds complex. I will leave it."
947: [12:30:00] <ss23> Is all the $allowed_actions stuff done now? Theres a heck of a lot of bugs on it
948: [12:30:00] <chillu> Not the $allowed_actions stuff though, that's too tricky
949: [12:31:00] <chillu> https://groups.google.com/forum/?fromgroups#!forum/silverstripe-announce
950: [12:31:00] <travis-ci> [travis-ci] Build details : http://travis-ci.org/silverstripe/sapphire/builds/5623969
951: [12:31:00] <travis-ci> [travis-ci] Change view : https://github.com/silverstripe/sapphire/compare/84a3de6be8f6...aa5f967b82af
952: [12:31:00] <travis-ci> [travis-ci] silverstripe/sapphire#1702 (post-2.4 - aa5f967 : Ingo Schommer): The build is still failing.
953: [12:31:00] * travis-ci has joined #silverstripe
954: [12:31:00] <chillu> I won't claim its completely free of bugs, but its had a lot of scrutiny and deliberation lately (resulting in patches to 2.4/3.0/3.1)
955: [12:31:00] <PigeonFriend> chillu: ok, I can take a look - where are the security announcements made?
956: [12:31:00] <travis-ci> [travis-ci] Build details : http://travis-ci.org/silverstripe/silverstripe-cms/builds/5623966
957: [12:31:00] * travis-ci has left #silverstripe
958: [12:31:00] <travis-ci> [travis-ci] silverstripe/silverstripe-cms#287 (post-2.4 - 7bbaaeb : Ingo Schommer): The build passed.
959: [12:31:00] * travis-ci has joined #silverstripe
960: [12:31:00] * travis-ci has left #silverstripe
961: [12:31:00] <travis-ci> [travis-ci] Change view : https://github.com/silverstripe/silverstripe-cms/compare/414f60ad2fa0...7bbaaeb76490
962: [12:33:00] * Guits has joined #silverstripe
963: [12:35:00] <PigeonFriend> chillu: heh, i know that feeling
964: [12:35:00] <PigeonFriend> I've had to manually patch that a few times
965: [12:35:00] <chillu> You don't happen to have fixed that in a fork somewhere?
966: [12:35:00] <chillu> gaaarr, I can't even run PHPUnit on 2.3 any more with PHPUnit 3.7
967: [12:36:00] <PigeonFriend> chillu: I'm just grabbing it
968: [12:36:00] <PigeonFriend> chillu: tbh, it's a very crude fix, i think. Its not to allow me to test, it's to stop the site breaking!
969: [12:37:00] <PigeonFriend> http://mhr.dev.betterbrief.co.uk/diff.txt
970: [12:38:00] <PigeonFriend> hmm, or maybe it does
971: [12:38:00] <PigeonFriend> chillu: i have no idea where that came from or what not, but I dont think it means we can run tests
972: [12:43:00] <PigeonFriend> Shrike_Finland: version of SS?
973: [12:43:00] <Shrike_Finland> 3.05 and soon will be testing on 3.1, too
974: [12:43:00] <Shrike_Finland> Hi guys! Little template question. I have "SlideContentAlign" => "Enum('Left, Center', 'Left')" on array, so can I use <% if $SlideContentAlign=center %> on template?
975: [12:44:00] <Zauberfisch> in my silverstripe boilerplate, should I ship polyfills?
976: [12:44:00] <Zauberfisch> <input placeholder="...">
977: [12:44:00] <Zauberfisch> current case:
978: [12:44:00] <Shrike_Finland> Or is there some better way to do it...
979: [12:45:00] <Zauberfisch> I have a javascript polyfill for that, would anyone disslike me shipping that with the silverstripe boilerplate?
980: [12:45:00] <kinglozzer> Shrike_Finland: Yes you can use that. You'll need the capital 'C' in Center though
981: [12:45:00] <PigeonFriend> Shrike_Finland: You should be able to do that in your template
982: [12:45:00] <PigeonFriend> Shrike_Finland not sure you need to have the $ before the var name though
983: [12:45:00] <ss23> FEELS GOOD MAN
984: [12:45:00] <ss23> Oh yeah, closing a 5 year old bug
985: [12:45:00] <Shrike_Finland> Nicely spotted!
986: [12:45:00] <Shrike_Finland> Ah! I think C was the problem!
987: [12:46:00] <Zauberfisch> ss23 you are a hero!
988: [12:46:00] <PigeonFriend> ss23: which?
989: [12:46:00] <ss23> http://open.silverstripe.org/ticket/1540
990: [12:46:00] <PigeonFriend> Zauberfisch: I don't see why including a polyfill like that is a bad idea
991: [12:46:00] <ss23> :D
992: [12:46:00] <Zauberfisch> seriously, I mean it
993: [12:47:00] <ss23> I'm just bored of dealing with the stupid JS stuff I dealt with all day, yet still felt like I should be productive! Luckiy silverstripe is not a bad project to sink time into when bored
994: [12:48:00] <PigeonFriend> chillu: problem I have with tests is I cant create the test DB tables because the syntax in core is TYPE=MyIsam and not Engine=
995: [12:51:00] * Guits quit (Read error: Connection reset by peer)
996: [12:51:00] * MrGuits has joined #silverstripe
997: [12:53:00] * ARNHOE quit (Remote host closed the connection)
998: [12:53:00] <ss23> Another 5 year old bug closed, BOOM
999: [12:56:00] <travis-ci> [travis-ci] silverstripe/silverstripe-cms#288 (3.0 - 0aeace2 : Ingo Schommer): The build passed.
1000: [12:56:00] * travis-ci has joined #silverstripe
1001: [12:56:00] <travis-ci> [travis-ci] Change view : https://github.com/silverstripe/silverstripe-cms/compare/79c9d3109947...0aeace2aecb7
1002: [12:56:00] <travis-ci> [travis-ci] Build details : http://travis-ci.org/silverstripe/silverstripe-cms/builds/5624308
1003: [12:56:00] * travis-ci has left #silverstripe
1004: [12:58:00] * DesignerX has joined #silverstripe
1005: [12:59:00] <DesignerX> SSViewer::current_theme() is returning the wrong theme !
1006: [12:59:00] <DesignerX> hi , how to get the name of the current theme in use in php ?
1007: [13:09:00] <travis-ci> [travis-ci] silverstripe/sapphire#1704 (3.0 - 52ffb30 : Ingo Schommer): The build passed.
1008: [13:09:00] * travis-ci has left #silverstripe
1009: [13:09:00] <travis-ci> [travis-ci] Build details : http://travis-ci.org/silverstripe/sapphire/builds/5624465
1010: [13:09:00] <travis-ci> [travis-ci] Change view : https://github.com/silverstripe/sapphire/compare/00bcdf39d3ce...52ffb307a7d1
1011: [13:09:00] * travis-ci has joined #silverstripe
1012: [13:11:00] * lx-berlin has left #silverstripe
1013: [13:11:00] * Zauberfisch_ has joined #silverstripe
1014: [13:14:00] <travis-ci> [travis-ci] Change view : https://github.com/silverstripe/silverstripe-cms/compare/75c77c436193...c3b4d686643a
1015: [13:14:00] <travis-ci> [travis-ci] silverstripe/silverstripe-cms#289 (3.1 - c3b4d68 : Ingo Schommer): The build passed.
1016: [13:14:00] * travis-ci has joined #silverstripe
1017: [13:14:00] * lx-berlin has joined #silverstripe
1018: [13:14:00] * travis-ci has left #silverstripe
1019: [13:14:00] <travis-ci> [travis-ci] Build details : http://travis-ci.org/silverstripe/silverstripe-cms/builds/5624646
1020: [13:15:00] * Zauberfisch quit (Ping timeout: 256 seconds)
1021: [13:16:00] * travis-ci has left #silverstripe
1022: [13:16:00] <travis-ci> [travis-ci] Change view : https://github.com/silverstripe/sapphire/compare/8538cb9ee202...53c84ee1fe81
1023: [13:16:00] <travis-ci> [travis-ci] Build details : http://travis-ci.org/silverstripe/sapphire/builds/5624651
1024: [13:16:00] * travis-ci has joined #silverstripe
1025: [13:16:00] <PigeonFriend> DesignerX: are you doing it in the CMS?
1026: [13:16:00] <travis-ci> [travis-ci] silverstripe/sapphire#1705 (3.1 - 53c84ee : Ingo Schommer): The build passed.
1027: [13:17:00] <DesignerX> hi again, if anyone has any idea why I get the wrong theme when using SSViewer::current_theme() , which is returning the theme set in the _config.php using SSViewer::set_theme('simple'); . Removing SSViewer::set_theme('simple') will cause SSViewer::current_theme() to return nothing ..
1028: [13:17:00] <PigeonFriend> because there is no theme in the CMS
1029: [13:17:00] <DesignerX> PigeonFriend: yeh, the call is on the CM side, on a widget
1030: [13:18:00] <DesignerX> PigeonFriend: what do you mean by no themes in the CMS ?
1031: [13:18:00] <Zauberfisch_> ok, done, polyfill is in the boilerplate
1032: [13:18:00] <DesignerX> shouldn SSViewer::current_custom_theme() retun the theme used ?
1033: [13:18:00] <PigeonFriend> DesignerX: what theme is it returning and what do you expect it to return?
1034: [13:19:00] <PigeonFriend> DesignerX: and what do you expect it to return?
1035: [13:19:00] <DesignerX> its returning simple which is set in the _config.php
1036: [13:19:00] <DesignerX> but it sould return UITS3 , which is what i have set in from the CMS setting section
1037: [13:20:00] <PigeonFriend> ok. and you're uusing that logic in a controller?
1038: [13:21:00] <ss23> For modules that are in https://github.com/silverstripe-labs/ (with github issue tracking turned on), should bugs be filed there, or on open.silverstripe?
1039: [13:21:00] <ajshort_> DesignerX: it doesn't actually run the bit of code that loads the theme from the cms unless you visit a page
1040: [13:21:00] <ajshort_> You can grab it using SiteConfig::current_site_config()->Theme
1041: [13:22:00] <DesignerX> ajshort_: that looks better :D .. will test it now
1042: [13:22:00] <chillu> ss23: Yes, where github issue tracking is available it should be used. We're phasing out Trac for all but core already
1043: [13:22:00] <chillu> It would be great if you can port over some issues there. Don't just close all of them please ;)
1044: [13:22:00] <ss23> THE BUG TRACKER SHALL BE SO CLEAN
1045: [13:22:00] <ss23> I'LL CLOSE 100 BEFORE I SLEEP TONIGHT, MUHAHAHAHA
1046: [13:22:00] <ss23> chillu: Sweet. Time to go on a rampage and close all these bugs for this module then, muahhaha
1047: [13:23:00] <DesignerX> ajshort_: that was the solution .. tyvm
1048: [13:23:00] <ss23> chillu: I'm only touching the ones that are > 1 year old. still want them ported or what?
1049: [13:23:00] <DesignerX> PigeonFriend: ajshort_ TY ,
1050: [13:24:00] <DesignerX> chillu: & in english ? :D
1051: [13:24:00] <chillu> So ensure that its clear where the issue came from, and where it went to. And see if the Trac username is also registered on github, in which case please CC him (through @ notation in github)
1052: [13:24:00] <ss23> chillu: Crap, I just realised, I closed a bunch of bugs for moduels that still exist in silverstripe-labs but arne't listed on the silverstripe modules stuff :O
1053: [13:24:00] <chillu> DesignerX: Gute Nacht!
1054: [13:24:00] <DesignerX> good night all, 12:30 am, zzzzZZZ time
1055: [13:24:00] <chillu> Here's an example of a ported issue: https://github.com/silverstripe-labs/silverstripe-googlesitemaps/issues/14
1056: [13:25:00] * MrGuits quit (Ping timeout: 272 seconds)
1057: [13:25:00] <ss23> I'll go through and transfer them instead
1058: [13:25:00] <chillu> For the flickrservice, youtubeservice etc? That's OK, but in general, yes you do need to be thorough and look for this stuff before closing tickets
1059: [13:25:00] <ss23> damn
1060: [13:26:00] <ss23> chillu: No, was thinking of the staticpublisher
1061: [13:26:00] <ss23> will take note in future though
1062: [13:26:00] <chillu> http://open.silverstripe.org/ticket/4583#comment:1? Yes, always assume those modules *do* still exist somewhere. A quick google will usually get you there
1063: [13:26:00] <ss23> chillu: on the silverstripe modules site it said unspported and not touched since 2009 or something. didn't realise that they weren't sync'd
1064: [13:27:00] <chillu> "unsupported" on ss.org is the default setting, so a lot of modules have it - that's not the same as "all bugs should be nuked" ;)
1065: [13:28:00] <ss23> chillu: I'll port them for you though, hows that
1066: [13:28:00] <ss23> chillu: Well, after the "we only want core reports" combined with no activity in the past 5 years, along with the "unspported", I *figured* I had covered my bases, alas, it was not so :<
1067: [13:28:00] * DesignerX quit (Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/)
1068: [13:32:00] <chillu> Would be cool if you could look through the newsletter module tickets a bit, and port over tickets which still appear outstanding: http://open.silverstripe.org/query?status=accepted&status=assigned&status=infoneeded&status=infoneeded_new&status=new&status=started&component=Modules+-+newsletter&col=id&col=summary&col=component&col=status&col=type&col=priority&col=milestone&order=priority
1069: [13:33:00] <chillu> So, this would be "newsletter module in 3.x", you can refer to me in saying that we won't fix legacy bugs which just apply to 2.x
1070: [13:33:00] <ss23> Yeah, thats what I was looking at when I asked, chillu. Will take a look tomorrow and see what I can find in there that could be closed
1071: [13:34:00] <chillu> Sicne the newsletter module is something we do still maintain (kind of)
1072: [13:34:00] <chillu> Just be aware the default should be "this is a bug unless I am fairly sure its been fixed", by looking at code or trying it out yourself
1073: [13:37:00] <ss23> There we are, all the staticpublisher ones migrated
1074: [13:39:00] * Martin__ has joined #silverstripe
1075: [13:41:00] <ss23> chillu: I'm heading off to bed now. Feel free to leave messages scolding me if I accidently became to zealous and closed more bugs than I should have (but I think most of the ones I nabbed were fine to close)
1076: [13:42:00] <chillu> Thanks SO MUCH for your work on the bugtracker, its great to see the community getting its hands dirty in there :)
1077: [13:49:00] * lx-berlin has left #silverstripe
1078: [14:11:00] * Zauberfisch__ has joined #silverstripe
1079: [14:11:00] * Zauberfisch_ quit (Read error: Connection reset by peer)
1080: [14:12:00] * lx-berlin has joined #silverstripe
1081: [14:13:00] * Shrike_Finland quit (Quit: Leaving.)
1082: [14:16:00] * travis-ci has left #silverstripe
1083: [14:16:00] * travis-ci has joined #silverstripe
1084: [14:16:00] <travis-ci> [travis-ci] silverstripe/sapphire#1706 (post-2.4 - ed9fa78 : Ingo Schommer): The build is still failing.
1085: [14:16:00] <travis-ci> [travis-ci] Change view : https://github.com/silverstripe/sapphire/compare/aa5f967b82af...ed9fa78fec09
1086: [14:16:00] <travis-ci> [travis-ci] Build details : http://travis-ci.org/silverstripe/sapphire/builds/5626145
1087: [14:17:00] * Guits has joined #silverstripe
1088: [14:20:00] <Marvanni> hm, why does confirmpassword field popuplates the _ConfirmPassword field after i submit the form again?
1089: [14:22:00] * Zauberfisch has joined #silverstripe
1090: [14:26:00] * Zauberfisch__ quit (Ping timeout: 245 seconds)
1091: [14:31:00] * guci0 has joined #silverstripe
1092: [14:49:00] * ajshort_ quit (Quit: ChatZilla 0.9.90-rdmsoft [XULRunner 18.0.2/20130201065344])
1093: [14:53:00] <bti> hello
1094: [14:53:00] * bti has joined #silverstripe
1095: [14:54:00] <bti> in SS3 is there anything special i need to do to get a custom $db field on Page to work with rollback/history?
1096: [15:09:00] * Alex______ has joined #silverstripe
1097: [15:10:00] <Alex______> Hello?
1098: [15:10:00] <Alex______> I'm following this tutorial: http://www.silverstriperesources.com/articles/silverstripe-3-data-grid-field/
1099: [15:10:00] <Alex______> Can someone help me with a SS 3.05 problem please?
1100: [15:11:00] * Zauberfisch quit (Read error: Connection reset by peer)
1101: [15:11:00] <Alex______> Which I don't understand.
1102: [15:11:00] * Zauberfisch_ has joined #silverstripe
1103: [15:11:00] <Alex______> [User Error] Uncaught LogicException: GridField doesn't have a modelClassName, so it doesn't know the columns of this grid.
1104: [15:11:00] <Alex______> and I;m getting this error:
1105: [15:13:00] <Alex______> Anyone?
1106: [15:14:00] <Alex______> One sec...
1107: [15:14:00] <Alex______> Sure I could but it's exactly the same
1108: [15:14:00] <kinglozzer> Alex_____ can you paste your code somewhere? www.pastie.org for example
1109: [15:15:00] <Alex______> k, here you go: http://pastie.org/6627521
1110: [15:16:00] <Alex______> I'm at this stage: 'At this stage, upload the files, run a dev/build and create a 'staffPage' in your CMS'
1111: [15:17:00] <Alex______> when I try to create the staff page I get that exception above.
1112: [15:18:00] * zenmonkey has joined #silverstripe
1113: [15:18:00] <kinglozzer> Alex_____ You've definitely run a dev/build? http://pastie.org/6627583 I've commented two bits out, try that
1114: [15:18:00] <Alex______> I ran http://localhost/dev/build?flush=1 kinglozzer
1115: [15:18:00] <zenmonkey> quick question, how do you disable Hash Link rewrite in SS3?
1116: [15:20:00] <kinglozzer> Alex_____: Line 15, $gridfield = new GridField("StaffMembers", "StaffMember", $this->StaffMembers, $gridFieldConfig); - I think it should be $this->StaffMembers() with brackets
1117: [15:21:00] <Alex______> ok, I', trying that now
1118: [15:22:00] <Alex______> Aha, it works :D
1119: [15:22:00] <Alex______> Thanks so much!
1120: [15:22:00] <peter_ss> guys have you tried assign a custom title to your $managed_model?
1121: [15:23:00] <peter_ss> static $managed_models = array('MyDo' => array('title' => 'Custom Title'));
1122: [15:24:00] <peter_ss> doesn't work
1123: [15:24:00] <Alex______> Oh... except I can't add staff kinglozzer
1124: [15:26:00] * furehead has joined #silverstripe
1125: [15:28:00] <furehead> Hi there, does anybody know whether blog module is compatible with sitetree_nested_urls ?
1126: [15:28:00] <peter_ss> or should I say how can I rename the add button text in the model admin
1127: [15:29:00] <furehead> I have a site with ss3.1 beta and blog module master... when the blogholder page is in a subdirectory I cannot open the blog entry pages. It gives me Action '[SiteName]' isn't available on class BlogHolder_Controller.
1128: [15:29:00] <Alex______> nvm, I got it working, thanks kinglozzer
1129: [15:30:00] * Alex______ quit (Quit: Page closed)
1130: [15:35:00] * catcher has joined #silverstripe
1131: [15:36:00] <kinglozzer> peter_ss: public static $singular_name = "Item";
1132: [15:36:00] <kinglozzer> Then it will say "Add new Item"
1133: [15:37:00] <peter_ss> I'm extending to model admin
1134: [15:37:00] <peter_ss> kinglozzer that didn't work
1135: [15:37:00] * catcher has joined #silverstripe
1136: [15:37:00] * catcher quit (Changing host)
1137: [15:38:00] <kinglozzer> peter_ss: Works fine for me in ModelAdmin
1138: [15:39:00] <peter_ss> what version?
1139: [15:40:00] <kinglozzer> 3.0.5, and 3.1-beta2
1140: [15:40:00] <furehead> Okay, sorry for asking. The blog module does not like dots (.) in blog-Entry URLs. Without dot it works.
1141: [15:41:00] <peter_ss> that's weird
1142: [15:41:00] * aaron1245 has joined #silverstripe
1143: [15:41:00] * furehead quit (Quit: Page closed)
1144: [15:43:00] <peter_ss> kinglozzer: I'm using dataobjectaspages module but that didn't work
1145: [15:44:00] <kinglozzer> peter_ss: I've never used that module, so can't help there I'm afraid
1146: [15:47:00] <peter_ss> kinglozzer anyway thanks man
1147: [15:49:00] * ocm quit ()
1148: [16:11:00] * Zauberfisch_ has joined #silverstripe
1149: [16:11:00] * Zauberfisch_ quit (Read error: Connection reset by peer)
1150: [16:20:00] * aaron1245 quit (Quit: aaron1245)
1151: [16:20:00] * Zauberfisch_ quit (Remote host closed the connection)
1152: [16:26:00] <elgrodo> peter_ss: I tried about a month ago, couldn't get it to work either
1153: [16:31:00] <peter_ss> i think there's an issue witht the getEditForm
1154: [16:31:00] <peter_ss> elgrodo is that for DataObjectPageasPages?
1155: [16:31:00] <peter_ss> funciton
1156: [16:37:00] * Marvanni quit (Ping timeout: 256 seconds)
1157: [16:38:00] * Marvanni has joined #silverstripe
1158: [16:42:00] * Zauberfisch-idle has joined #silverstripe
1159: [16:42:00] * Zauberfisch^idle quit (*.net *.split)
1160: [16:44:00] * zenmonkey quit (Quit: This computer has gone to sleep)
1161: [16:44:00] * Martin__ quit (Ping timeout: 245 seconds)
1162: [16:55:00] * Shrike_Finland has joined #silverstripe
1163: [17:01:00] * micmania1 has joined #silverstripe
1164: [17:08:00] * zfmf has joined #silverstripe
1165: [17:08:00] * zfmf has left #silverstripe
1166: [17:11:00] * aaron1245 has joined #silverstripe
1167: [17:13:00] * aaron1245 quit (Client Quit)
1168: [17:17:00] * kinglozzer quit (Remote host closed the connection)
1169: [17:25:00] * bti quit (Quit: Textual IRC Client: www.textualapp.com)
1170: [17:43:00] * SphereSilver has joined #silverstripe
1171: [17:51:00] <FrozenFire> Does something in SSViewer fuck with HTML entities?
1172: [17:51:00] <FrozenFire> I need to output ordinal HTML entities for some regular characters, but when I do so, I get regular characters.
1173: [17:51:00] <SphereSilver> Probably, to prevent injection?
1174: [17:52:00] <FrozenFire> Even when checking using wget and a text editor
1175: [17:53:00] <FrozenFire> http://www.sspaste.com/paste/show/5148a607f0f35
1176: [17:56:00] <SphereSilver> What if you change, in your template, to let it output .raw?
1177: [17:56:00] <SphereSilver> like, $Content.Raw?
1178: [17:57:00] <FrozenFire> Nada
1179: [17:59:00] <FrozenFire> Or unmangled, as it were.
1180: [17:59:00] <FrozenFire> If I Debug::dump it in the controller, it's as I want it to be.
1181: [17:59:00] <FrozenFire> Definitely something in the view parser
1182: [17:59:00] <FrozenFire> One the view gets ahold of it, it gets mangled.
1183: [18:00:00] <SphereSilver> That's strange. Do you have an example of wished and actual output?
1184: [18:00:00] * zenmonkey has joined #silverstripe
1185: [18:01:00] <FrozenFire> In the source, that is
1186: [18:01:00] <FrozenFire> http://afs.clients.mediadevils.com/connect/north-central-region/
1187: [18:01:00] <FrozenFire> Compare the debug output to the other output
1188: [18:05:00] * zenmonkey quit (Client Quit)
1189: [18:09:00] <SphereSilver> It could be me... but they are exactly the same to me in debug as in normal mode.
1190: [18:10:00] <SphereSilver> The source that is, ignoring the early start of the debug-output
1191: [18:17:00] * PigeonFriend quit ()
1192: [18:47:00] * elgrodo quit (Ping timeout: 276 seconds)
1193: [18:54:00] * gelignite has joined #silverstripe
1194: [18:56:00] * SightUnseen has left #silverstripe
1195: [18:56:00] * SightUnseen has joined #silverstripe
1196: [19:02:00] * Liquide has joined #silverstripe
1197: [19:04:00] <simon_w> FrozenFire, stick in a $casting for the method as a HTMLText
1198: [19:04:00] * elgrodo has joined #silverstripe
1199: [19:05:00] <FrozenFire> Did
1200: [19:20:00] * lx-berlin has left #silverstripe
1201: [19:28:00] <elgrodo> peter_ss: I think so (the module that enables data objects as pages) - within an ss3 context
1202: [19:36:00] * nickmolhoek has joined #silverstripe
1203: [19:36:00] * nickmolhoek quit (Remote host closed the connection)
1204: [19:36:00] * nickmolhoek has joined #silverstripe
1205: [19:37:00] * elgrodo quit (Ping timeout: 256 seconds)
1206: [19:38:00] * aaron1245 has joined #silverstripe
1207: [19:40:00] * DigNZ has joined #silverstripe
1208: [19:40:00] * DigNZ has joined #silverstripe
1209: [19:40:00] * DigNZ quit (Remote host closed the connection)
1210: [19:44:00] * liam has joined #silverstripe
1211: [19:49:00] * elgrodo has joined #silverstripe
1212: [19:52:00] * Pyromanik has joined #silverstripe
1213: [20:19:00] * willr has joined #silverstripe
1214: [20:21:00] * chillu has left #silverstripe
1215: [20:28:00] * UndefinedOffset quit (Quit: Leaving.)
1216: [20:31:00] * ARNHOE has joined #silverstripe
1217: [20:36:00] * ARNHOE has joined #silverstripe
1218: [20:36:00] * ARNHOE quit (Remote host closed the connection)
1219: [20:37:00] * C10ne quit (Ping timeout: 245 seconds)
1220: [20:39:00] * ARNHOE has joined #silverstripe
1221: [20:39:00] * ARNHOE quit (Remote host closed the connection)
1222: [20:39:00] * UncleCheese has joined #silverstripe
1223: [20:41:00] * SightUnseen has joined #silverstripe
1224: [20:44:00] * ARNHOE quit (Remote host closed the connection)
1225: [20:44:00] * ARNHOE has joined #silverstripe
1226: [20:50:00] * SightUnseen quit (Ping timeout: 256 seconds)
1227: [20:59:00] * azureKnight has joined #silverstripe
1228: [21:03:00] * azureKnight_ has joined #silverstripe
1229: [21:05:00] * azureKnight_ is now known as azureKnight
1230: [21:05:00] * azureKnight quit (Ping timeout: 255 seconds)
1231: [21:07:00] * DigNZ quit (Quit: DigNZ)
1232: [21:16:00] * DigNZ has joined #silverstripe
1233: [21:16:00] * DigNZ quit (Client Quit)
1234: [21:17:00] * liam has left #silverstripe
1235: [21:24:00] * liam has joined #silverstripe
1236: [21:32:00] * ARNHOE quit (Remote host closed the connection)
1237: [21:33:00] * ARNHOE has joined #silverstripe
1238: [21:34:00] <travis-ci> [travis-ci] silverstripe/silverstripe-cms#290 (3.1 - 1f14654 : Ingo Schommer): The build passed.
1239: [21:34:00] <travis-ci> [travis-ci] Change view : https://github.com/silverstripe/silverstripe-cms/compare/c3b4d686643a...1f14654649a4
1240: [21:34:00] <travis-ci> [travis-ci] Build details : http://travis-ci.org/silverstripe/silverstripe-cms/builds/5639394
1241: [21:34:00] * travis-ci has left #silverstripe
1242: [21:34:00] * travis-ci has joined #silverstripe
1243: [21:35:00] * ARNHOE quit (Remote host closed the connection)
1244: [21:36:00] * zfmf has left #silverstripe
1245: [21:37:00] * ARNHOE has joined #silverstripe
1246: [21:39:00] * DigNZ has joined #silverstripe
1247: [21:39:00] * DigNZ has joined #silverstripe
1248: [21:39:00] * DigNZ quit (Remote host closed the connection)
1249: [21:39:00] * ARNHOE quit (Remote host closed the connection)
1250: [21:40:00] * DigNZ quit (Client Quit)
1251: [21:41:00] * SightUnseen has joined #silverstripe
1252: [21:42:00] * liam quit (Quit: liam)
1253: [21:45:00] * SightUnseen1 has joined #silverstripe
1254: [21:46:00] * SightUnseen1 has left #silverstripe
1255: [21:47:00] * azureKnight quit (Ping timeout: 252 seconds)
1256: [21:47:00] * azureKnight_ is now known as azureKnight
1257: [21:47:00] * azureKnight_ has joined #silverstripe
1258: [21:48:00] * SightUnseen quit (Ping timeout: 264 seconds)
1259: [21:53:00] * UncleCheese quit (Quit: UncleCheese)
1260: [21:54:00] * DigNZ quit (Remote host closed the connection)
1261: [21:54:00] * DigNZ has joined #silverstripe
1262: [21:54:00] * DigNZ has joined #silverstripe
1263: [22:01:00] * liam has joined #silverstripe
1264: [22:02:00] <FrozenFire> UGGGH. SSViewer or whatever-the-fuck is doing this to my HTML entities needs to fuck off quite seriously right now.
1265: [22:02:00] <FrozenFire> Hours. Hours spent on this field.
1266: [22:03:00] <FrozenFire> Tried casting
1267: [22:03:00] <FrozenFire> Tried raw
1268: [22:03:00] <FrozenFire> Tried hacking certain static global state
1269: [22:03:00] <FrozenFire> So at some point between my model and my controller, this shit is getting mangled.
1270: [22:03:00] <FrozenFire> I've verified beyond a reasonable doubt that this method is returning the right value.
1271: [22:03:00] <FrozenFire> Tried reading through the whole goddamn template parser
1272: [22:04:00] <FrozenFire> Grepped the shit out of the sources.
1273: [22:05:00] <FrozenFire> I'm about ready to scream
1274: [22:06:00] <travis-ci> [travis-ci] Build details : http://travis-ci.org/chillu/sapphire/builds/5640363
1275: [22:06:00] * travis-ci has joined #silverstripe
1276: [22:06:00] <travis-ci> [travis-ci] chillu/sapphire#81 (pulls/node-count-callback - 8915369 : Ingo Schommer): The build failed.
1277: [22:06:00] <travis-ci> [travis-ci] Change view : https://github.com/chillu/sapphire/compare/50995fbecb4b^...8915369b5e0f
1278: [22:06:00] * travis-ci has left #silverstripe
1279: [22:08:00] <FrozenFire> 'Bout ready to hulk smash it
1280: [22:14:00] * Motoservo_ has joined #silverstripe
1281: [22:15:00] * Motoservo quit (Ping timeout: 248 seconds)
1282: [22:15:00] * liam quit (Quit: liam)
1283: [22:15:00] * Motoservo_ is now known as Motoservo
1284: [22:16:00] <Pyromanik> FrozenFire, what is issue?
1285: [22:16:00] * liam has joined #silverstripe
1286: [22:17:00] <Pyromanik> trying to HTML in your label?
1287: [22:18:00] <FrozenFire> Nope
1288: [22:19:00] <FrozenFire> It does so by simply converting a bunch of characters in the email addresses to ordinal HTML entities.
1289: [22:19:00] <FrozenFire> You would utterly not believe the lengths I've gone to trying to fix this seemingly simple issue.
1290: [22:19:00] <FrozenFire> I have a getter on a page which obfuscates email addresses in the Content field.
1291: [22:19:00] <FrozenFire> Something is converting them back to characters.
1292: [22:20:00] <FrozenFire> Like, it abso-fucking-lutely *will not* allow HTML entities through
1293: [22:20:00] * onre quit (Ping timeout: 240 seconds)
1294: [22:21:00] <FrozenFire> Ever.
1295: [22:22:00] <FrozenFire> Have an &nbsp; in your source? Space character.
1296: [22:23:00] <Pyromanik> christopher content walker'n
1297: [22:27:00] <FrozenFire> There are so many things that could get in the way
1298: [22:27:00] <FrozenFire> -.-
1299: [22:27:00] <FrozenFire> And I've read through most of them
1300: [22:27:00] <Pyromanik> simon_w, what's the name of that class that fucks everything like this up?
1301: [22:27:00] <FrozenFire> This is quite possibly the worst bug I've ever encountered
1302: [22:29:00] <simon_w> Only things I know of that do that are .LimitCharacters and .RAW
1303: [22:31:00] <simon_w> The horrible ContentNegotiator goes the other way
1304: [22:32:00] <simon_w> Well, manually doing a Convert::*2raw
1305: [22:33:00] <simon_w> Which RAW may or may not do, depending on if it's an actual map to RAW_val
1306: [22:36:00] <FrozenFire> Sure doesn't help that Chrome is a twat.
1307: [22:38:00] * catcher quit (Quit: Leaving)
1308: [22:39:00] <FrozenFire> Any template.
1309: [22:39:00] <FrozenFire> Nope. Chrome's not a twat. Still SS.
1310: [22:39:00] <FrozenFire> It'll convert &nbsp;, but not &amp;
1311: [22:39:00] <FrozenFire> And we're not even talking about in a field any more
1312: [22:39:00] * onre is now known as Guest12275
1313: [22:39:00] * onre has joined #silverstripe
1314: [22:40:00] * Guest12275 is now known as onre_
1315: [22:40:00] * Guest12275 has joined #silverstripe
1316: [22:40:00] * Guest12275 quit (Changing host)
1317: [22:41:00] * Squandered has joined #silverstripe
1318: [22:42:00] <simon_w> Let me guess, 3.1-ish, after http://doc.silverstripe.org/framework/en/3.1/changelogs/3.1.0#default-cast-is-now-text was merged?
1319: [22:42:00] * SightUnseen has joined #silverstripe
1320: [22:43:00] <FrozenFire> It's text in a file.
1321: [22:43:00] <FrozenFire> I'm talking about putting &nbsp; in a template
1322: [22:43:00] * SightUnseen quit (Read error: Connection reset by peer)
1323: [22:43:00] <FrozenFire> I don't think so
1324: [22:43:00] <FrozenFire> That gets rewritten
1325: [22:43:00] <FrozenFire> Not in any sort of DB field.
1326: [22:44:00] <Squandered> soo... If I just extract 3.1 over 3.0.5.... will I blow the thing up?
1327: [22:45:00] <FrozenFire> (E.g. git)
1328: [22:45:00] <FrozenFire> Are you versioning your project with a SCM?
1329: [22:46:00] <simon_w> Squandered, yes. The world will implode.
1330: [22:46:00] <Squandered> I'll be right
1331: [22:46:00] <Squandered> just found the upgrading docs
1332: [22:46:00] <Squandered> thought as much _b
1333: [22:51:00] <FrozenFire> I'm so tired of this bug.
1334: [22:51:00] <FrozenFire> So very tired.
1335: [22:52:00] <FrozenFire> There's no conceivable reason for this...
1336: [22:52:00] <FrozenFire> I've even looked in Apache for something... anything...
1337: [22:58:00] * eikonos quit (Quit: Leaving.)
1338: [22:59:00] * eikonos has joined #silverstripe
1339: [22:59:00] * eikonos quit (Changing host)
1340: [22:59:00] * eikonos has joined #silverstripe
1341: [23:06:00] * liam quit (Quit: liam)
1342: [23:18:00] <azureKnight> Has anybody been having trouble with ss3.1 and sending emails via a contact form?
1343: [23:19:00] <willr> azureKnight make sure you have set a from address in the cms
1344: [23:19:00] * UncleCheese has joined #silverstripe
1345: [23:19:00] <azureKnight> willr: I am using your user forms on it, and it all seems to be working great, but the emails aren't coming through. I sent an email to my web host and seeing if it's something on their end. The user forms module is as amazing as ever, by the way. :)
1346: [23:20:00] <willr> and that it's from your domain
1347: [23:20:00] <azureKnight> http://digitaldecree.com
1348: [23:20:00] <azureKnight> But they share the domain?
1349: [23:20:00] <azureKnight> What if your email is going through gmail?
1350: [23:23:00] * nickmolhoek quit (Quit: nickmolhoek)
1351: [23:24:00] <Pyromanik> yes, contentnegotiator is the one I was thinking of
1352: [23:24:00] <Pyromanik> <simon_w> The horrible ContentNegotiator goes the other way
1353: [23:24:00] * SphereSilver quit (Remote host closed the connection)
1354: [23:24:00] <Pyromanik> I've never looked at it, I don't even know what it does.
1355: [23:25:00] <Pyromanik> but it even SOUNDS problematic, just by the class title.
1356: [23:27:00] * tankr has joined #silverstripe
1357: [23:31:00] * Squandered quit (Ping timeout: 245 seconds)
1358: [23:31:00] * DigNZ quit (Quit: DigNZ)
1359: [23:35:00] * DigNZ has joined #silverstripe
1360: [23:38:00] * DigNZ quit (Client Quit)
1361: [23:40:00] * azureKnight quit (Quit: azureKnight)
1362: [23:42:00] * nicolaas_ has joined #silverstripe
1363: [23:43:00] * Squandered has joined #silverstripe
1364: [23:43:00] <nicolaas_> hi everyone.... I have a casted HTMLText field that for some reason shows up "escaped" (I see <img src rathe than an image) in the gridfield in modeladmin. Does anyone know how to fix this and if this is a bug?
1365: [23:46:00] <simon_w> nicolaas_, you need to return the HTMLText object, not just cast it
1366: [23:49:00] * DigNZ has joined #silverstripe
1367: [23:49:00] * DigNZ quit (Remote host closed the connection)
1368: [23:49:00] * DigNZ has joined #silverstripe
1369: [23:51:00] <nicolaas_> Ahhhh - GOT IT ;-) Thank you Simon_w, as always. I thought that is what casting was supposed to do for you. Simon, if you'd charged $1 for each correct answer provided on here then you would have been the new Bill Gates by now. YOU ROCK!
1370: [23:52:00] <simon_w> Casting is predominately a template thing
1371: [23:53:00] <simon_w> And almost no one would pay if I charged :p

These logs were automatically created by ss-log on irc.freenode.net.